Contributors mailing list archives
Re: Additional information regarding how-to review moduleby
Camptocamp SA, Joël Grand Guillaume
Hi,Tha'ts a good question ! I've updated the doc again with the following suggestion:
- Two reviewers must approve a merge proposal in order to be able to merge it
- 5 calendar days must be given to be able to merge it
- A MP can be merged in less that 5 calendar days if and only if it is approved by 3 reviewers. If you are in a hurry just send a mail at email@example.com or ask by IRC (FreeNode oca, openobject channel).
- At least one of the review above must be from a member of the PSC
Is everybody alright with this ?
On Mon, Oct 26, 2015 at 11:53 AM, Andhitia Rama <firstname.lastname@example.org> wrote:
@Daniel:Thank your for your suggestion. Will try it ASAP.On Mon, Oct 26, 2015 at 5:07 PM, Daniel Reis <email@example.com> wrote:Lorenzo is correct, any person can submit reviews, you just need to have a Github account. Not required, but IMO submitting a PR and going through the review process first is helpful to get you familiarized with the process. --Daniel--
OpenSynergy Indonesia, Andhitia Rama