Contributors mailing list archives
Re: 100 % coverage not enough?by
Camptocamp SA, Simone Orsi
I replied on the PR.
On Fri, Sep 8, 2023 at 8:57 PM Ronald Portier <firstname.lastname@example.org> wrote:
Hi all, I submitted a PR with 100% code coverage to the account-invoicing repo. However the branch is red because 100% is apparently not enough. Supposedly the PR would decrease the overall coverage percentage. How?? See here: https://github.com/OCA/account-invoicing/pull/1544 I think any PR that gets code coverage > 90% (and that does not decrease coverage of an existing module), should get a branch green, but certainly 100%. Kind regards, Ronald
Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.