Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Re: 100 % coverage not enough?
by
Camptocamp SA, Simone Orsi
Hi Ronald,
I replied on the PR.
Bests
On Fri, Sep 8, 2023 at 8:57 PM Ronald Portier <notifications@odoo-community.org> wrote:
Hi all, I submitted a PR with 100% code coverage to the account-invoicing repo. However the branch is red because 100% is apparently not enough. Supposedly the PR would decrease the overall coverage percentage. How?? See here: https://github.com/OCA/account-invoicing/pull/1544 I think any PR that gets code coverage > 90% (and that does not decrease coverage of an existing module), should get a branch green, but certainly 100%. Kind regards, Ronald_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Simone Orsi
Full stack Python web developer,
Odoo specialist,
Odoo Community Board Member,
in love with open source.