Contributors mailing list archives

Browse archives


Re: 100 % coverage not enough?

Moduon Team, S. L., Jairo Llopis
- 11/09/2023 10:09:27
El vie, 08-09-2023 a las 18:57 +0000, Ronald Portier escribió:
Supposedly the PR would decrease the overall coverage percentage. How??

The 1st thing you need to know is that hose checks are not required.

Now, this is how your PR looks:

That ✅ is telling the reviewer that the PR has a 100% of coverage. That's the important part.

The ❌ however is the weirdo. Sometimes it happens, so I systematically ignore that check. IMHO it could be removed. My guess is that the base branch evolved and got more coverage, and that if you rebased it would always increase. But maybe it's just a bug somewhere.