Contributors mailing list archives

contributors@odoo-community.org

Re: Odoo Issue management

by
Cody Kitterman
- 01/06/2016 02:25:28
Dave:

     My chief criticisms would be that it's written in Go, when Odoo is maintained by Python developers, and that it revolves around Docker. Still, the same thing be achieved using a bot (e.g. something like the "Odoo Translation Bot") in conjunction with an expanded commit message convention. For instance, gitchangelog introduces the concept of an "Audience" within commit messages, but let's hold off on that for just a second. 

Here's an example of the current output of git log:
$ git log
commit 610d4627405ab0c5479007164d9e11bbe44d5f00
Author: Odoo Translation Bot <c3p@odoo.com>
Date: Sun May 15 00:29:02 2016 +0200

[I18N] Update translation terms from Transifex

commit 780e3fec10e2f1f25a0d5530aad3d114249dcce7
Author: Nicolas Lempereur <nle@odoo.com>
Date: Fri May 13 17:30:58 2016 +0200

[FIX] l10n_be_intrastat: get location_id from stock move

purchase.order have been rewritten with cb01be2

It was not taken into account for intrastat who still used the now not
existing "location_id" on purchase order.

This commit use instead the method _get_destination_location which

If the details could be worked out, and the convention could be expanded to include an "Audience" prefix, it might look something like the following:
$ git log
commit 610d4627405ab0c5479007164d9e11bbe44d5f00
Author: Odoo Translation Bot <c3p@odoo.com>
Date: Sun May 15 00:29:02 2016 +0200

[TRANS(lators)][UPDATE] il18n: Update translation terms from Transifex

commit 780e3fec10e2f1f25a0d5530aad3d114249dcce7
Author: Nicolas Lempereur <nle@odoo.com>
Date: Fri May 13 17:30:58 2016 +0200

[DEVS][FIX] l10n_be_intrastat: get location_id from stock move

purchase.order have been rewritten with cb01be2

It was not taken into account for intrastat who still used the now not
existing "location_id" on purchase order.

This commit use instead the method _get_destination_location which
Other audience members might include:  

'usr' is for final users (UI changes)
'pkg' is for packagers (packaging changes)
'test' is for testers (test only related changes)
'doc' is for doc guys (doc only changes)


Now, assuming Odoo S.A. is willing to enforce a convention, a bot could be written to turn these prefixes into something useful:

commit 44d5f00
pr-manager-bot added new translation label on May 13, 2016

pr-manager-bot commented on May 16, 2016
@mart-e New Translation 

pr-manager-bot commented on May 20, 2016
@mart-e Needs Review

pr-manager-bot added
 need review label on May 20, 2016

...


https://github.com/odoo/odoo/wiki/BugManagement#issues
NameTopic
@rco-odooNew API, framework
@xmo-odooCSV import
@qdp-odooAccounting, Accounting reports
@jco-odooStock, MRP
@gde-odoo, @aab-odooDiscuss, 9.0 Web client, Livechat
@tde-odooMail, Porting modules to new API
@GorashWebsite editor
@jke-odooCRM, website_(sale|forum|blog|...)
@mart-eTranslations
@sle-odooQWeb assets, Reports, Mobile apps
@tac-odooAwesome timesheets
@qsm-odooLESS/CSS themes
@KangOlMigrations, OAuth
@dbo-odoo9.0 contracts, website_quotes
@nim-odoo9.0 sales, timesheets, purchase
@apr-odooUsability, on-boarding
...... Feel free to amend...

This would just be for starters... I'm thinking Odoo could use it to learn more about their developers, too—who develops what, skillsets, etc—but more importantly we'd have the beginnings of a change log via gitchangelog. Hell, you could turn the bot into a finite state machine that opened new issues and handled transitions: "modules x has recently been updated, but the documentation hasn't been updated: here's what changed..."

But I digress...

R/S
Cody K.

On Mon, May 30, 2016 at 6:23 PM, David Arnold <dar@devco.co> wrote:
Here is a quite nice example of GordonTheTurtel in action:
Probably it's worth looking at the Turtle's Code: https://github.com/docker/gordon
If I get it right, it is as straightforward as adding people to the respective MAINTAINERS

El mié., 25 may. 2016 a las 15:08, moy lop (<moylop260@gmail.com>) escribió:

Thank you Cody Kitterman

They are talking about assign, but I can't assign...

Daniel,
Should I requested you a assign?

El 25/05/2016 02:38 p.m., "Cody Kitterman" <ckitterm@gmail.com> escribió:
This is where the bot, proposed by Mr.Reis, and the expanded commit message conventions (See: "gitchangelog to odoo and it's modules") would come in handy.

That said:
NameTopic
@rco-odooNew API, framework
@xmo-odooCSV import
@qdp-odooAccounting, Accounting reports
@jco-odooStock, MRP
@gde-odoo, @aab-odooDiscuss, 9.0 Web client, Livechat
@tde-odooMail, Porting modules to new API
@GorashWebsite editor
@jke-odooCRM, website_(sale|forum|blog|...)
@mart-eTranslations
@sle-odooQWeb assets, Reports, Mobile apps
@tac-odooAwesome timesheets
@qsm-odooLESS/CSS themes
@KangOlMigrations, OAuth
@dbo-odoo9.0 contracts, website_quotes
@nim-odoo9.0 sales, timesheets, purchase
@apr-odooUsability, on-boarding
...... Feel free to amend...
Src: https://github.com/odoo/odoo/wiki/BugManagement#issues

R/S
Cody K

On Wed, May 25, 2016 at 12:08 PM, Moises Lopez <moylop260@vauxoo.com> wrote:
Hi Daniel,

This could be cool to expedite the PRs
I have a pair of basic changes but abandoned:


Small changes since a long time ago but abandoned. 
I add ping to odoo team but I don't have response...

What should be the correct way to expedite them?

2016-05-25 2:53 GMT-05:00 Lorenzo Battistini <lorenzo.battistini@agilebg.com>:
On 25 May 2016 at 00:09, Cody Kitterman <ckitterm@gmail.com> wrote:
Does that mean you want us to look through the issues and, if we should find something, "@dreispt" or "@yenthe666" with a reason why we think it should be closed? ;-)


Hi,
about who to ping, you can look at this


--
Lorenzo Battistini
Tel (IT): +39 011 198 25481

_______________________________________________

--
Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
Mobile: (+521) 477-752-22-30
Office: (+52) 477-773-33-46
web: http://www.vauxoo.com
twitter: @vauxoo
           @moylop260           

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe