Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: The future of oca/bank-payment

by
DIXMIT Consulting SLU, Enric Tobella Alomar
- 26/03/2025 12:43:26
Well, I would like to give my opinion, as this is a big topic.

IMO, the idea is interesting but has a lot of issues when we go to practice.

For example with the current system we can decide the bank to pay at the end in a simple way, no complication on that side. With this change, everything becomes more complicated, removing part of the functionality that we have and it was much better that the current Odoo behavior. Also, it implies that users will see one TRansference payment method for each journal, and that is a nonsense.

Also, Odoo proposes to generate the payment on the invoices and merge them together at the end to generate the SEPA files, but this si completly different in our case, as we create the payments when we have grouped the moves. Trying to fit both behaviors together might be problematic in the end as the intentions of the fields are completly different.

Personally, I think that we can imagine some benefits, but we will loose functionalities on the change and that is something that is not interesting.

Trying to reuse something that Odoo SA did for EE might have sense, but in this case, it doesn't fit the effort IMO. So, I would prefer to avoid this big change.

My 2 cents.

El mié, 26 mar 2025 a las 12:27, Pedro M. Baeza (<notifications@odoo-community.org>) escribió:
I have expressed my rejection specifically on this new approach due to a lot of reasons:

- It's complicating everything, not easing it.
- It requires a lot of effort to adapt to it. Both users and developers need to change all they know.
- There's no need for this change.
- It's not bringing any value.

I have exposed all the detailed reasons on the PRs with no answer from anybody.

But it's not only that. It's the continuous contempt of Alexis refusing to follow the general OCA guidelines that we all agreed:

- One PR per module migration.
- Split changes by batches for being reviewable and debatable.
- Not clear commit history.
- Etc.

And I personally have pinged him tens of times for checking fixes or improvements in this set of modules with 0 answers. He disappears during a year and a half, and then comes with a pull request that is changing 108 files at the same time, with breaking changes, and trying to impose to the rest these non agreed changes. I don't think it's fair, even if he is able to do good code.

If you want to go this way, you should start a new module set, with different names, but leave the current ones unaltered. We are superseding this week the existing migrations on the current approach to finish them and getting them merged, as several top contributors companies like ForgeFlow, Dixmit and Tecnativa need them already.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
Enric Tobella Alomar
CEO & Founder

Reference