1. Mailing Lists
  2. Contributors
  3. Re: Changes in Ocabot - nobump will be now required

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Changes in Ocabot - nobump will be now required

Re: Changes in Ocabot - nobump will be now required

Avatar

Re: Changes in Ocabot - nobump will be now required

by
ClosingAp Open Source Integrators Europe, LDA, Daniel Reis
- 14/04/2020 23:47:19
Stéphane, thanks for these details, I was not awar of the non-dev wheels.
I suggest, for version migrations, for the PR to use a version number below 1.0.0, such as 0.0.0, or 0.0.1, and then do the merge with \ocabot merge major.


On 14/04/2020 17:52, Stéphane Bidoul wrote:
Hi Denis,

For migration, where you already have the version number in the manifest you have two options
- /ocabot merge nobump: will keep the version in the manifest, the drawback is that you don't have a wheel with a round version number (it will get a .dev suffix depending on the number of commits in the module since the commit that set the manifest version)
- /ocabot merge patch: will do a patch version and a round wheel version number, the drawback being that you don't have a 1.0.0 and you go right away to 1.0.1

Tradeoffs... :)

Best regards,

-sbi

On Tue, Apr 14, 2020 at 10:52 AM Roussel, Denis <denis.roussel@acsone.eu> wrote:
Thanks for the great job !

One question: for migration PR's, what's the best practice (as the good version number is already set) ?

On Tue, Apr 14, 2020 at 10:36 AM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
Hi all,

We recently worked with Stephane Bidoul from Acsone, to improve the OCA bot that makes a lot of automated tasks on github. (https://github.com/OCA/oca-github-bot/)

FIY, the merge command syntax will change (PR). Previously, it was possible to say \ocabot merge. It will be now mandatory to mention the bump method to apply, among these 4 options : major, minor, patch, or nobump.
The nobump option should be used in rare cases. Most of the time, please follow the OCA conventions, regarding version numbers, available here.
Remark : if the command is incorrect, the bot will now answer that the command was wrong. Sample.

Another changes are available for the OCA bot :
* Possibility to automatically update history.rst file, using oca-towncrier and fragments files (PR). If you're interested in such a feature, please take a look at that new OCA command, available in maintainer-tools project.

Note 1 : There are also pending works to have the possibility to rebase the current pull request (PR) or to (auto) squash the commit of a PR. Feel free to contribute !

Note 2 : For people that have installed a custom ocabot for their custom repositories, new settings are available.
* Possibility to have approvals required configurable. (PR)
* Possibility to add options, calling oca-gen-addons-table, oca-gen-addon-readme, oca-gen-addon-icon (PR)
* Possibility by the configuration file, to disable bot tasks (PR) and ignore github status (PR)

Kind regards.

Sylvain LE GAL - Twitter
GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)
Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Bureau : (+33) 09.72.32.33.17 - Astreinte : (+33) 06.81.85.61.43
Member of the OCA (Odoo Community Association)

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
__________________________________________
Denis Roussel
Software Engineer
Acsone SA, Succursale de Liège (Val Benoît)
Tel    : +32 2 888 31 49
Fax   : +32 2 888 31 59
Gsm : +32 472 22 34 64

Acsone sa/nv
Boulevard de la Woluwe 56 Woluwedal | B-1200 Brussels  | Belgium
Quai Banning, 6 (Val Benoît) | B-4000 Liège | Belgium
Zone Industrielle 22 | L-8287 Kehlen | Luxembourg

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


Reference