Contributors mailing list archives
Re: "Adopt a Module" campaign?by
Acsone SA/NV, Stéphane Bidoul
Excellent! Enabling such a campaign was part of the goals when we added the maintainer role back then.
Doing it in the travis lint phase is perhaps too big a step? An alternative could be to have the bot commenting on new pull requests for addons that have no maintainers.
On Tue, Nov 19, 2019 at 10:42 AM Alexey Pelykh <email@example.com> wrote:
I agree to volunteer, as long as we agree on approach and steps. In my mind, every repository should have a “Adopt Me” issue with “help” wanted, where bot will maintain a list of modules that are not adopted. And periodic "call for maintainers” on events?As for lint: have no idea how to approach this, “if commit has a new file __manifest__.py then do something"On 19 Nov 2019, at 11:27, Sylvain LE GAL <firstname.lastname@example.org> wrote:Le mar. 19 nov. 2019 à 10:17, Pedro M. Baeza (Tecnativa) <email@example.com> a écrit :Well, OK for both, but resources are needed to perform that, so if you volunteer for performing them, +1 for me.Regards.El mar., 19 nov. 2019 a las 10:12, Alexey Pelykh (<firstname.lastname@example.org>) escribió:How to perform that?Ask them, very-very politelyTecnnically,- In a first step, it's quite easy to add maintainers keys in the odoo modules that fetch github code. (https://github.com/OCA/interface-github)- In a second step a nice bot can create PR adding maintainers for some (all modules). (a little more complex, but not so hard) Can be an objective of a code sprint.regard.Are you suggesting Travis to fail if no maintainer is declared?For new modules, yes. For current ones - give warning. It makes no sense of adding module and not becoming a maintainer for it (unfortunately, I did the same for some time because lack of knowledge)
On 19 Nov 2019, at 11:02, Pedro M. Baeza (Tecnativa) <email@example.com> wrote:> 1) “noone”’s modules should be adopted either by their original author(s) or by volunteerHow to perform that?> 2) add a lint to ensure when module is added, it has a declared maintainerAre you suggesting Travis to fail if no maintainer is declared?Regards.