1. Mailing Lists
  2. web
  3. Re: [OCA/web] 10.0-fix-issue-727 (#1010)

web mailing list archives

web@odoo-community.org

Browse archives

Re: [OCA/web] 10.0-fix-issue-727 (#1010)

Re: [OCA/web] 10.0-fix-issue-727 (#1010)

Avatar

Re: [OCA/web] 10.0-fix-issue-727 (#1010)

by Karan Shah <notifications@github.com> - 03/08/2018 14:13:32

@karan-dreambits requested changes on this pull request.

In web_confirm_window_close/static/src/js/web_confirm_window_close.js:

> @@ -10,6 +10,7 @@ odoo.define('web_confirm_window_close', function (require) {
             if ($('html').find('.oe_form_dirty').length) {
                 e.preventDefault();
             }
+            return 'Your have unsaved data. Are you sure you want to close window?';

As discussed earlier and as @Tardo found here

https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload#Notes

Starting with Firefox 44, Chrome 51, Opera 38 and Safari 9.1, a generic string not under the control of the webpage will be shown instead of the returned string.

Any string returned would be ignored anyways and in older browser string would work just find and display their default generic dialog so better way is it to return blank string.

Please return blank string instead of this custom message

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.