1. Mailing Lists
  2. web
  3. Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

web mailing list archives

web@odoo-community.org

Browse archives

Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

Re: [OCA/web] [FIX][web_menu_navbar_needaction] mute logger for assertRaises (#1213)

Avatar

Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

by Rafael Blasco <notifications@github.com> - 18/07/2019 15:19:21

Hi @max3903 ,

I don't think is good practice to merge with a disagree of a PCS, you should then ask maybe another PSC in @OCA/web-maintainers but not merge.

You add Coyright, Author and 2 contribution by changin " by ' 7008038 plus 4 lines of code 7008038#diff-7a2fc2224315edb7571db98b9462f6e1

We must also maintain the same criteria for all when it comes to attributing contributions or authorizations. If you make a migration of a module with a diff of 40 lines of which code change are 4 lines, then what is the criterion. You have to be fair.

This is not something that of course takes away the dream, it is not harmful for Tecnativa. But it is harmful and unfair in my personal opinion for OCA and the rest of the contributors.

Regards

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.