1. Mailing Lists
  2. Human Resources
  3. Re: [OCA/hr] [12.0][IMP] hr_holidays_leave_auto_approve: Auto-approve for everyone (#663)

Human Resources mailing list archives

hr@odoo-community.org

Browse archives

Re: [OCA/hr] [12.0][IMP] hr_holidays_leave_auto_approve: Auto-approve for everyone (#663)

Re: [OCA/hr] [12.0][IMP] hr_holidays_leave_auto_approve: Auto-approve for everyone (#663)

Avatar

Re: [OCA/hr] [12.0][IMP] hr_holidays_leave_auto_approve: Auto-approve for everyone (#663)

by Jaime Arroyo <notifications@github.com> - 19/11/2019 12:15:28

@jarroyomorales commented on this pull request.

In hr_holidays_leave_auto_approve/models/hr_leave.py:

>                  values.get('holiday_status_id')
-            ).auto_approve
+            )
+            auto_approve = leave_type.auto_approve_policy != 'no'

Don't you think we can just delete the _get_auto_approve_on_creation() function? It is used to disable the creation message in case the leave can be auto approved, which I dont undersand why. IMHO it is not necessary to do that

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.