1. Mailing Lists
  2. Human Resources
  3. Re: [OCA/hr] [12.0][ADD] hr_holidays_accrual: Advanced accrual leave allocations (#501)

Human Resources mailing list archives

hr@odoo-community.org

Browse archives

Re: [OCA/hr] [12.0][ADD] hr_holidays_accrual: Advanced accrual leave allocations (#501)

Re: [OCA/hr] [12.0][ADD] hr_holidays_accrual: Advanced accrual leave allocations (#501)

Avatar

Re: [OCA/hr] [12.0][ADD] hr_holidays_accrual: Advanced accrual leave allocations (#501)

by "Pedro M. Baeza" <notifications@github.com> - 26/03/2019 18:02:30

@pedrobaeza commented on this pull request.

In hr_holidays_accrual/__manifest__.py:

> +    'installable': True,
+    'application': False,
+    'summary': 'Advanced accrual leaves allocation',
+    'depends': [
+        'hr_holidays',
+        'hr_employee_service',
+    ],
+    'external_dependencies': {
+        'python': [
+            'dateutil',
+        ],
+    },
+    'data': [
+        'security/hr_holidays_accrual_security.xml',
+        'security/ir.model.access.csv',
+        'wizard/hr_leave_allocation_accrual_calculator.xml',

Yes, for consistency with other folders, better to use plural here, as seen in the template:

https://github.com/OCA/maintainer-tools/tree/master/template/module/wizards

or guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#file-naming

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.