Contributors mailing list archives

contributors@odoo-community.org

Re: Migration to version 9

by
Camptocamp SA, Guewen Baconnier
- 07/09/2015 08:03:50
On Mon, Sep 7, 2015 at 9:37 AM, Daniel Reis <dgreis@sapo.pt> wrote:
>> Still, with 2. most of the history will be the same than 8.0 and then
>> only a few commits will need to be forwarded from 8.0 to 9.0 when
>> migrating a module which has 3 effects:
> This is also true for option 3 (delete unported modules from the repo),
> and it doesn't have the disadvantage of the unported modules cluttering
> the repo root.
>
>   /DR
>
> _______________________________________________


The option 3 shows the entire diff when we submit a PR, which was
already one of the big issue of the __unported__ folder.
Having the diff showing what has been migrated is really necessary for
reviewers IMO. Your workaround to do the porting work in a second
commit might work for small addons, but bigger addons need more than 2
commits and we can't review commit per commit.

Handling the cluttering of uninstallable addons in a repository is a
one-off work, doing the migration and reviewing work is the thing on
which most people will pass most of the time, so this is what we
should make easy and I really think 2. is better for that.