Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Re: Migration to version 9
by
ClosingAp Open Source Integrators Europe, LDA, Daniel Reis
Thanks for the summary Joël.
Many modules do not get ported to the next version, maybe they are obsolete or maybe nobody has interest in using them anymore.
IMO a requirement is that available/ported modules are immediately recognizable looking at the root directory.
Just acting on the __openerp__.py inside unported modes does not achieve that.
I can only see two options, rename the modules (maybe by prepending a dot) or move them to a directory, such as __unported__.
It seems that the main objection to start with an empty branch is the history for ported modules.
But afaik git filter-branch keeps file history.
Can someone elaborate on this?
--DR
JoëlRegards,I prefer b) because I don't need to edit the file to know if it is ported or not.b) Renaming the __openerp__.py to __unported.py__a) active = False in the manifest* Two options to keep module at root folder and not use git filter :* Not fan to use git filter per module and prefer merges* +1 for not using the __unported__ folderHi,So as a summary of what I read:
Thanks for the initiative ! I'm also in favor of deleting the __unported__ folder. But -1 for using git filter-branch and moving each module (a clean git history matter).On Thu, Aug 27, 2015 at 8:38 AM, Guewen Baconnier <guewen.baconnier@camptocamp.com> wrote:Thanks for this proposal! I strongly agree with the removal of __unported__. But I'm -1 for the migration per module using filter-branch for the same reason that Stéphane and for another very reason: it does not support the renaming of a module so the history would stop at the first git mv. -- Guewen Baconnier On Wed, Aug 26, 2015 at 8:23 PM, <Bidoul@pad.odoo-community.org> wrote: > Another big con is that the forward port process by a git merge of 8.0 into > 9.0 is not possible. > > I'll think to it a little bit more but I'd say at this stage I'm not a huge > fan of this method. I believe the disadvantages outweight the small benefit > of hiding unported modules. > > At some point there was a proposal of > - keeping unported modules with active=False > - having an (autogenerated) list of modules and their status in the > README.md of the repository > > That proposal plus an systematic forward port process is my favorite > approach at this point. > > -sbi > > On Wed, Aug 26, 2015 at 7:52 PM, <Pedro@pad.odoo-community.org> wrote: >> >> Pros of this method: >> >> Avoid a lot of commits starting the branch. >> Avoid commits of deprecated modules. >> Avoid having outdated version that was put on __unported__ when release >> version was out, but later modified on the previous version. >> Avoid forgetting to use the version in __unported__. >> No misunderstanding for newcomers about the existence of the module in the >> __unported__ folder. >> No need to remove any module. >> >> Cons of this method: >> >> It requires a process to start a PR a bit more complicated than before. >> Reviewers should check if the commit history is well-extracted. >> Contribution statistics are disturbed by this process (although it can be >> easily filtered by distinct commits). >> >> So we think the number of pros is better than the cons, and that's why we >> propose this. >> >> Please comment any possible thing we haven't figure out. >> >> Regards. >> >> >> >> 2015-08-26 19:23 GMT+02:00 Maxime Chambreuil >> <maxime.chambreuil@savoirfairelinux.com>: >>> >>> Dear OCA contributors >>> >>> Pedro and I proposed a new process to manage the coming migration from 8 >>> to 9 : >>> >>> https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9-%28WIP%29>>> >>> Main thing is to get rid of the __unported__ directory as it contains >>> outdated versions of modules. We want to migrate the latest version and >>> avoid duplicating PR against many branches. >>> >>> Version 9 is still more than a month ahead, so we have time to review, >>> discuss and agree on this proposal. >>> >>> Cheers, >>> -- >>> Maxime Chambreuil >>> +1 (514) 276-5468 #126 >>> >>> _______________________________________________ >>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15 >>> Post to: mailto:contributors@odoo-community.org >>> Unsubscribe: http://odoo-community.org/groups?unsubscribe >> >> >> _______________________________________________ >> Mailing-List: http://odoo-community.org/groups/oca-contributors-15 >> Post to: mailto:contributors@odoo-community.org >> Unsubscribe: http://odoo-community.org/groups?unsubscribe > > > _______________________________________________ > Mailing-List: http://odoo-community.org/groups/oca-contributors-15 > Post to: mailto:contributors@odoo-community.org > Unsubscribe: http://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe
--
camptocampINNOVATIVE SOLUTIONSBY OPEN SOURCE EXPERTSJoël Grand-GuillaumeDivision ManagerBusiness Solutions_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe
Reference
-
Migration to version 9
byOpen Source Integrators, Maxime Chambreuil-
Re: Migration to version 9
byClosingAp Open Source Integrators Europe, LDA, Daniel Reis