Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: Self-merging rule

by
Leonardo Pistone
- 24/08/2015 08:32:48
I won't make it too strict. I consider the maintainers a group of
people I know and trust, and I don't feel a need for more bureocracy
than what we have now.

A few times I asked a fellow maintainer to merge a PR they'd approved
already, at I felt this was pure bureaucracy (because they'de approved
it anyway). Moreover, I feel it is not such a problem for me since I
often have other maintainers in the same room, but people like Pedro
need to find someone on irc which might take a moment more.

Anyway, if people prefer to keep the no-self-merge rule as it is, no
problem for me of course. If from time to time, someone feels it is a
good idea to merge anyway (i.e. a hotfix, approved by maintainers,
noone around on IRC) I won't complain for sure.

Aside: in the future, a place where I would instead like to add an
extra step is releases. We'll see maybe for v9...


On Mon, Aug 24, 2015 at 10:07 AM, Houssine BAKKALI
<houssine.bakkali@gmail.com> wrote:
> Agreed with Graeme separation of duty should be the standard even it not
> really feasable today. maybe adding x days before be able to self merge
> could be a temporary solution.
>
> 2015-08-23 23:23 GMT+02:00 Graeme Gellatly <gdgellatly@gmail.com>:
>>
>> it is still a conflict,  perceived or otherwise.  To me it is just good
>> governance to not allow it.  Separation of responsibilities.
>>
>> At least for me.
>>
>> Sent from TypeMail
>>
>> On 24 Aug 2015, at 8:38 AM,
>> Pedro@pad.odoo-community.orgServ.@pad.odoo-community.org wrote:
>>>
>>> Having merge privileges (currently only 58 people are able to) means that
>>> you are already used to deal with community people and knows if the given
>>> approvals have the needed confidence to merge or not. The problem is the
>>> same that someone that has to merge have: knowing if the PR can be merged or
>>> not, so I don't think your arguments goes against the self-merge possibility
>>> itself.
>>>
>>> Regards.
>>>
>>> 2015-08-23 21:08 GMT+02:00 Maxime Chambreuil
>>> <maxime.chambreuil@savoirfairelinux.com>:
>>>>
>>>> +1
>>>>
>>>> Anybody can review and put a +1. Having 3 +1 from less experienced
>>>> contributors does not mean you can merge your own PRs.
>>>> --
>>>> Maxime Chambreuil
>>>> +1 (514) 276-5468 #126
>>>>
>>>> ----- Le 23 Aoû 15, à 14:53, Graeme Gellatly <gdgellatly@gmail.com> a
>>>> écrit :
>>>>
>>>> Hi
>>>>
>>>> I'm with Stefan on this. People with merge rights know everybody else
>>>> with merge rights and are respected.  It should be no big deal to just ask
>>>> one on Irc to take a quick check and merge.
>>>>
>>>> The only exceptions should be if one of the approvals was by someone
>>>> with merge rights or it is non Odoo code,  eg new tests,  Travis config but
>>>> even then I'd prefer not.
>>>>
>>>> The act of merging is more than just simply pressing a button it
>>>> represents an absolute approval by one of the repositories most senior
>>>> members.  Self merging undermines that.
>>>>
>>>> Well at least to me.
>>>>
>>>>
>>>> Sent from TypeMail
>>>>
>>>> On 24 Aug 2015, at 12:22 AM, Pedro Manuel Baeza Romero
>>>> <pedro.baeza@gmail.com> wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> I faced some days ago a complaint from Stefan Rijnhart about myself
>>>>> merging one of my PRS when the number of approvals was the appropiate. This
>>>>> is an old OCA rule that was applied on old Launchpad times.
>>>>>
>>>>> This rule is not even in the current OCA contributing guidelines (
>>>>> https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#review),
>>>>> but he insists on bringing this topic to the mailing list.
>>>>>
>>>>> I see no special reason to apply again this rule nowadays, because
>>>>> thanks to the merge button, the task doesn't involve any special risk to
>>>>> screw up things. In Launchpad, there was this risk, as the merge implies
>>>>> some manual operations that can lead to a bad merging, but as I said, today
>>>>> this is not a problem.
>>>>>
>>>>> What the others think about this rule?
>>>>>
>>>>> Regards.
>>>>>
>>>>> _______________________________________________
>>>>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
>>>>> Post to: mailto:contributors@odoo-community.org
>>>>> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>>>>
>>>> _______________________________________________
>>>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
>>>> Post to: mailto:contributors@odoo-community.org
>>>> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
>>>> Post to: mailto:contributors@odoo-community.org
>>>> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>>>
>>>
>>> _______________________________________________
>>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
>>> Post to: mailto:contributors@odoo-community.org
>>> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>>
>> _______________________________________________
>> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
>> Post to: mailto:contributors@odoo-community.org
>> Unsubscribe: http://odoo-community.org/groups?unsubscribe
>
>
> _______________________________________________
> Mailing-List: http://odoo-community.org/groups/oca-contributors-15
> Post to: mailto:contributors@odoo-community.org
> Unsubscribe: http://odoo-community.org/groups?unsubscribe

Reference