Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: Better contribution recognition

by
Opener B.V., Stefan Rijnhart
- 13/04/2018 09:17:20
Hi,

I have tried to lobby for a karma system on OCA projects on Github that, as a CI, posted messages to encourage the submitter to do more reviews if he or she does not do enough and consequentially makes the CI 'fail' to indicate this karma to other reviewers. It does not prevent a good PR to be submitted or merged regardless of the karma of the submitter but it does give nudges.

Given that we require two or three approvals per PR, and there are sometimes more reviewers involved, I'm thinking that one PR is offsetted by three reviews. Maybe this idea should be promoted more because I have the impression that new submitters see it as a task (or a privilege?) of the project members to do all the reviews instead of everyone's task.

As for the idea of paying people to do the reviews, I find that terrible. Doing reviews is incredibly valuable in itself as you learn a lot from it both technically, functionally and socially. As such, it is an integral part of improving the Odoo community as a whole and we should strive to have everyone participate in that. Then again, it is not always a fun job. It would hurt my motiviation to do them as a volunteer if other people get paid to do it (especially if they don't do a formidable job).

Regards,
Stefan.



On 04/12/2018 03:17 PM, Rafael Blasco wrote:

+1 Holger IMHO

 

 

De: Holger Brunn [mailto:hbrunn@therp.nl]
Enviado el: miércoles, 4 de abril de 2018 9:02
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Better contribution recognition

 

> Maybe there other good ideas out there.
 
> What would you suggest the OCA to do?
 
I'm musing for a long time about something I call OCA karma.
 
In a very rough version you'd start out with +10 when you submit your
CLA. For every PR you open, you lose a karma point, for every
review/merge you get one. When your karma is zero, you can't open new
PRs (and maybe existing ones are demoted somehow). Or we could order PRs
by current karma of the author.
 
Sounds simple enough, but there are quite some complications: There are
PRs which actually should increase karma (greenifying PRs mostly;
hotfixes), how to avoid sick incentives (If we for example give extra
karma for merging a PR, people might get sloppy and merge prematurely),
how to deal with bullshit reviews made just for increasing one's own
karma? Do issues have an effect on karma and if yes, which? How to make
the above less single minded technical?
 
But I think above complications can be worked out if a few people look
into it. This should also have some kind of decay, so that people like
me can't sit on previous work for years.
 
 
-- 
Therp - Maatwerk in open ontwikkeling
 
Holger Brunn - Ontwerp en implementatie
 
mail: holger@therp.nl
web: http://therp.nl
phone: +31 (0)20 3093096
 

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



-- 
Opener B.V. - Business solutions driven by open source collaboration

Stefan Rijnhart - Consultant/developer

mail: stefan@opener.am
tel: +31 (0) 20 3090 139
web: https://opener.am

Reference