Contributors mailing list archives

contributors@odoo-community.org

Re: CI Builds now uses requirements from odoo repository

by
Leonardo Rochael Almeida
- 13/07/2017 20:44:53
By the way,

Adding `simplejson` back to `requirements.txt` is also unnecessary if you do a global replace:

 - `simplejson` -> `json`
 - `simplejson.JSONDecodeError` -> `ValueError`

For reference, see the commits at:

https://github.com/odoo/odoo/pull/6940/commits

Cheers,

Leo

On 12 July 2017 at 16:21, Leonardo Rochael Almeida <leorochael@gmail.com> wrote:
Hi,

On 12 July 2017 at 16:08, Moises Lopez <moylop260@vauxoo.com> wrote:
Before:
 - We had a custom requirements.txt from OCA/maintainer-quality-tools (MQT) repository.

Now:
 - We deleted the previous custom requirements.txt from MQT
 - We are using the original odoo's requirements.txt

PR:

New possible errors
[...]
2. odoo 10.0 deleted packages.
  - Example "unittest2"

Solutions
For both cases the fix is adds explicitly the package and version to requirements.txt root file of your project.

Please, for the unittest2  case, do not re-add the file to `requirements.txt`. Instead simply replace all references to `unittest2` to `unitest` in your addon.

`unittest2` is a backport of `unittest` from Python 2.7 back to earlier versions of Python. There is no reason to use it.

Best regards,

Leo