Contributors mailing list archives

contributors@odoo-community.org

Re: Codacy usage

by
ThinkOpen Solutions Portugal, Daniel Reis
- 22/05/2017 14:36:20

Yes Alex, I added it.
The service has quite some potential, including static analysis for security issues.

But it is not properly configured, and need time to have it use or lint confs.
In the meanwhile it can be annoying, so go ahead disabling it.
 

--
Regards
Daniel


Citando Alexandre Fayolle <alexandre.fayolle@camptocamp.com>:

On closer inspection, I think Daniel Reis could be the one who added it.

Daniel, is it ok with you if I remove the web hook?

Alexandre

On 22/05/2017 15:54, Pedro Manuel Baeza Romero wrote:
> I have just said the same on my PR:
> https://github.com/OCA/project/pull/187#issuecomment-303087341
> 
> +1 for deactivating it.
> 
> Regards.
> 
> 2017-05-22 15:23 GMT+02:00 Alexandre Fayolle
> <alexandre.fayolle@camptocamp.com
> <mailto:alexandre.fayolle@camptocamp.com>>:
> 
>     Hello
> 
>     I see some projects such as OCA/project are using Codacy as part of the
>     webhooks. The net effect is that all PRs are red because codacy does not
>     know about __manifest__.py, unused imports and such. This makes
>     reviewing the PRs harder than needed IMO
> 
>     I'm therefore questionning the decision behind the use of this tool, at
>     least without a configuration which filters out the blatant false
>     positives.
> 
> 
> 
> 
>     -- 
>     Alexandre Fayolle
>     Chef de Projet
>     Tel : +33 4 58 48 20 30 
> 
>     Camptocamp France SAS
>     Savoie Technolac, BP 352
>     73377 Le Bourget du Lac Cedex
>     http://www.camptocamp.com
> 
>     _______________________________________________
>     Mailing-List: https://odoo-community.org/groups/contributors-15
>     
>     Post to: mailto:contributors@odoo-community.org
>     <mailto:contributors@odoo-community.org>
>     Unsubscribe: https://odoo-community.org/groups?unsubscribe
>     
> 
> 
> _______________________________________________
> Mailing-List: https://odoo-community.org/groups/contributors-15
> Post to: mailto:contributors@odoo-community.org
> Unsubscribe: https://odoo-community.org/groups?unsubscribe
> 


-- 
Alexandre Fayolle
Chef de Projet
Tel : +33 4 58 48 20 30

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe