1. Mailing Lists
  2. Contributors
  3. Re: Proposal for new Label in Github

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Proposal for new Label in Github

Re: Proposal for new Label in Github

Avatar

Re: Proposal for new Label in Github

by
Elico Corp, Eric Caudal
- 04/04/2017 04:00:00

Because their might be a delay of 5 days before you can merge.

Besides it could used by bot to automatically approve and then merge

--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore)
Odoo Gold Partner // Best Odoo Partner APAC 2014 and 2016
On 04/04/2017 09:52 AM, Maxime Chambreuil wrote:
<blockquote cite="mid:CADkUELnsd4VtnqVEAp7m6sGCaT+N7PSO6tRDE+rV_Z2K9fuKkg@mail.gmail.com" type="cite">
When will we use it? If the pull request is ready for merging, why don't we merge it in the first place? The people who can tag are the same as the ones who can merge, no?

Ursa Information Systems Maxime Chambreuil
Project Manager / Consultant

Ursa Information Systems
1450 W Guadalupe Road, Suite 132
Gilbert, Arizona, 85233

Office:     1-855-URSA ERP x 710
                1-855-877 2377 x 710
Mobile:   1-602-427-5632

On Mon, Apr 3, 2017 at 9:08 AM, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
OK then!

2017-04-03 17:38 GMT+02:00 David Lasley <dave@dlasley.net>:

Approved is a tag in some repos, but not in others it seems. Maybe we should just make that one official & apply to missing repos instead?

— Dave Lasley

On Apr 3, 2017, at 2:23 AM, Eric Caudal <eric.caudal@elico-corp.com> wrote:

I dont think so:

<img src="cid:part1.F5306FE6.91A46605@elico-corp.com" alt="">
--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore)
Odoo Gold Partner // Best Odoo Partner APAC 2014 and 2016
On 04/03/2017 04:38 PM, Pedro M. Baeza (Tecnativa) wrote:
<blockquote cite="mid:CACSANCChU9PdAaF8OTMYDKcKMe3HUeY5xgTA51M2g10CfQqVYw@mail.gmail.com" type="cite">
There's already the label "Approved" for that AFAIK...

Regards.

2017-04-03 3:53 GMT+02:00 Eric Caudal <eric.caudal@elico-corp.com>:

Hi,

I would like to add a new label in Github: "Ready for Merge", to be used as soon as 2 approvals have been achieved.

It would help the core maintainers to track down readied PR.


What do you think?



--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore)
Odoo Gold Partner // Best Odoo Partner APAC 2014 and 2016

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


<span id="cid:6966BE52-8A64-4124-B4AC-6AB5DA9354EA@dlasley.net"><likdldafilpinhpp.png>

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


Reference