Contributors mailing list archives

contributors@odoo-community.org

Re: Merge/squash commits in pull requests

by
levent@mektup.at
- 25/01/2017 14:36:26
This is very useful for new contributors. Thanks!

2017-01-20 11:53 GMT+03:00 Lorenzo Battistini <lorenzo.battistini@agilebg.com>:
On 19 January 2017 at 12:08, Jordi Ballester Alomar <jordi.ballester@eficent.com> wrote:
Dear community members,

We have created a wiki page in OCA/maintainer-tools that provides some guidance in merging/squashing commits in preparation for merging a pull request into OCA repositories.


We hope that this can make it easier for all to know how to address the task when required. 

Please no not hesitate to send feedback!


Thanks Jordi, this is very useful.

2 remarks:

The page talks about squash but it then uses fixup. In general I would use squash, except when squashing OCA Transbot commits, where I would use fixup.

Then, at the end of the guide, I would add
git push -f
to make clear that history has to be overwritten

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe