1. Mailing Lists
  2. Contributors
  3. Re: New Github Review Options

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: New Github Review Options

Avatar

Re: New Github Review Options

by
Elico Corp, Eric Caudal
- 17/09/2016 00:47:37

+1

The new review process is much easier.

I am not sure about the roles and options that are offered and how to enforce them.

--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APAC
On 09/17/2016 06:08 AM, Dave Lasley wrote:
<blockquote cite="mid:0075EE6A-1F1C-43B8-91A7-419371CD8C30@laslabs.com" type="cite">

Hi All,


As you have likely noticed - Github has just gotten a bit fancier by offering us a real review process + some project management capabilities.

We are now able to configure a certain amount of reviews per repository, instead of this :+1 situation we have been working with. 

I propose that we implement these rules (2 approvals required) on OCA repos so that the review approval process is part of our standard CI spot. 

Anyone have any thoughts on this?

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


Reference