1. Mailing Lists
  2. Contributors
  3. Re: Proposal for new workflow, incorporating "Optimistic Merging"

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Louvain-la-Neuve Code Sprint

Re: Proposal for new workflow, incorporating "Optimistic Merging"

Avatar

Re: Proposal for new workflow, incorporating "Optimistic Merging"

by
Savoir-faire Linux, David Dufresne
- 07/06/2016 15:05:28 
I agree with Rafael at 100%,

I think this approach will weaken OCA.

If you merge an unstable PR (I mean a PR with fuzzy code or not enough test or badly documented), who will
take the responsibility after that to improve the module?

When a module is already merged, this means that someone else might be using it in production. This makes
it very difficult to improve without affecting people who are using the module.

My last point is, the most problem with new contributors, and I was my-self one of them 2 years ago, is not
mostly about the technical quality of code. Sometimes, the module is not coherent at all or not generic.
Example, a module that is not multi-currency or not multi-company. Sometimes, it is extremely specific to
the needs of one company.

And when a fuzzy module is merged, good luck removing it. It might take more time and more effort then
what was taken to create a review the module in the beginning.

:-1: for the global approach

David Dufresne, Consultant en logiciels libres
Savoir-faire Linux

Téléphone  : 418-525-7354 #156
Cell       : 418-271-0915
Ring ID    : 9ac472765d298cc5de294b5765d0ccfaec48cbbf
www.savoirfairelinux.com

ISO 9001 et ISO 14001

----- Original Message -----
From: "Rafael Blasco" <rafael.blasco@tecnativa.com>
To: "contributors" <contributors@odoo-community.org>
Sent: Tuesday, June 7, 2016 7:23:07 AM
Subject: Re: Proposal for new workflow, incorporating "Optimistic Merging"

Hi @ll,
I'm not agree in an optimistic merging approach. This opinion depends of what do you think OCA is and OCA can be.
OCA must ensure the quality of modules. This modules must be robust and never fail. OCA is a community that Customers take as reference of things well done, something that they can trust.
Odoo is an ERP which fight with the big ones and implement Business processes worldwide. This is not CMS. Two examples: (1) You cannot trust in 99% of wordpress modules (2) In Odoo Apps store there are many many modules that are more a problem for the customer than a benefic (even-though you pay for it).
When a customer trust in Odoo don't want to be optimistic, wants no risk for the investment. Customer must trust in OCA,
Furthermore, in my experience, I quoted projects based in "what is done thanks of OCA" so Customer can afford project. This was absolutely a big mistake and I must said "we must develop everything". Because you don't expect to find such a bugs that you must refactor everything. This means that optimistic merging will create a feeling of " uncertainty OCA".
Do we want more contributors? What is a contributor, someone who make PRs or someone who review PRs? Both. We need more reviewers too.
Code Contributors in OCA must thanks what they will learn thanks to OCA and the experimented reviewers. They will significantly improve their professional skills. With optimistic merging which is the challenge?
What will happens with the difference between contributors? The ones who make big efforts to make stable software, then ones who make quick software.
Maybe it should be an "OCA Quality" and "OCA optimistic", meaning of their stamps will be very different and the we will ask customer: do you want to be optimistic and take a risk? or do you want to be sure about what your business software will do?
Let's make last question. Why someone wants to put their modules to OCA?
- Because they will have visibility --> Why OCA have more visibility? Because you will find a well done work.
- Because modules will be reviewed without cost
OCA deserves  an effort because many people have  worked hard to get  this reputation worldwide.

Regards,
Rafael

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

Reference