1. Mailing Lists
  2. Contributors
  3. Re: external review tools (was Re: Should we use the new GitHub reactions?)

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: external review tools (was Re: Should we use the new GitHub reactions?)

Re: external review tools (was Re: Should we use the new GitHub reactions?)

Avatar

Re: external review tools (was Re: Should we use the new GitHub reactions?)

by
Camptocamp SA, Joël Grand Guillaume
- 21/03/2016 10:25:19
Ahah ! Graeme, I missed you sometimes ;) ! Everything alright in New Zealand ?

On Fri, Mar 18, 2016 at 8:08 PM, Graeme Gellatly <gdgellatly@gmail.com> wrote:

... Is shit.  There you go,  finished it for you Joel.


On Fri, 18 Mar 2016 11:37 PM Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> wrote:
Agree with Laurent. Everyone knows github...

On Fri, Mar 18, 2016 at 10:38 AM, Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
Be careful. Even if an other tool may help to ease the review process it's also a new barrier to attract new contributors. 

m2¢

lmi

On Fri, Mar 18, 2016 at 10:08 AM, Eric Caudal <eric.caudal@elico-corp.com> wrote:

Thanks for the check: reviewable.io looks promising but indeed we should test it first.
Another one that we are experimenting internal (more for checking comment resolution) is https://www.codereviewhub.com/ but not sure you can have have the +1 feature as we want

Make code reviews on GitHub much easier!
    Keep track of unaddressed comments.
    Keep track of open issues.
    No more lost file comments due to changing diffs!
    One-click cloud installation and 100% free!

--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APAC
On 03/18/2016 04:38 PM, Alexandre Fayolle wrote:
<blockquote cite="mid:56EBBA99.2090605@camptocamp.com" type="cite"> 
I've noticed there are a number of external review systems for the
Github environment which we may want to use. Popular choices include

* https://www.review.ninja/
* https://reviewable.io/


Quick comparison from reading the sites of both tools (I have not used
any as of now)

Review Ninja
------------

* beta version, sponsored by SAP , legalese contract to sign,
which does not look quite nice, may not be free for OSS projects
* allows to put flags such as [fix] in github review comments which are
displayed in the PR status
* uses "ninja stars" for approvals. It is possible to configure a
minimum number of stars for a PR to become successful, and it seems easy
to check who gave a star to a PR
* github team integration
* notifications can be sent when ninja stars are given
* the doc is available and seems clear

reviewable.io
-------------

* pay for private project, free for OSS model
* review done in another app
* LGTM button, presumably with reports / notifications
* possible to resolve opinion on individual review comments
* review messages have a workflow: draft / publish
* link to Travis in review tool
* can write rules for review completion
* nice dashboard
* "review me on reviewable.io" button on PR

I'm tempted to set up reviewable.io for a couple of repositories, in
order to evaluate it. The FAQ warns that mixing github review and
reviewable.io review is not optimal: "While comments posted in one will
also appear in the other, line comments will turn into top-level
comments due to the systems' irreconcilable approaches to line
numbering. Also, Reviewable expects that all participants are using its
system for tracking unreviewed files and unresolved comments, so if some
people are using GitHub those counters probably won't be right."

(https://github.com/Reviewable/Reviewable/wiki/FAQ)

What do you think?


-- 
Alexandre Fayolle
Chef de Projet
Tel : +33 4 58 48 20 30

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--
Laurent Mignon
Senior software engineer

Tel: +352 20 21 10 20 32
Fax: +352 20 21 10 21
Email: laurent.mignon@acsone.eu

Acsone SA, Succursale de Luxembourg 
22, Zone Industrielle
​ ​
​| L-8287 Kehlen, Luxembourg
TVA LU24733605
​ | ​RCS B160400​

​
Acsone sa/nv
Boulevard de la Woluwe 56, b4  Woluwedal
​ | B-1200 Bruxelles - Brussel 
RPM Bruxelles 0835.207.216 RPR Brussel  


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--


camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Joël Grand-Guillaume
Division Manager


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--


camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Joël Grand-Guillaume
Division Manager
Business Solutions

+41 21 619 10 28


Reference