Contributors mailing list archives
Re: external review tools (was Re: Should we use the new GitHub reactions?)by
... Is shit. There you go, finished it for you Joel.On Fri, 18 Mar 2016 11:37 PM Joël Grand-Guillaume <email@example.com> wrote:Agree with Laurent. Everyone knows github...On Fri, Mar 18, 2016 at 10:38 AM, Mignon, Laurent <firstname.lastname@example.org> wrote:Be careful. Even if an other tool may help to ease the review process it's also a new barrier to attract new contributors.m2¢lmi--On Fri, Mar 18, 2016 at 10:08 AM, Eric Caudal <email@example.com> wrote:
Thanks for the check: reviewable.io looks promising but indeed we should test it first.
Another one that we are experimenting internal (more for checking comment resolution) is https://www.codereviewhub.com/ but not sure you can have have the +1 feature as we want
Make code reviews on GitHub much easier!
Keep track of unaddressed comments.
Keep track of open issues.
No more lost file comments due to changing diffs!
One-click cloud installation and 100% free!--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APACOn 03/18/2016 04:38 PM, Alexandre Fayolle wrote:<blockquote cite="mid:56EBBA99.firstname.lastname@example.org" type="cite">I've noticed there are a number of external review systems for the Github environment which we may want to use. Popular choices include * https://www.review.ninja/ * https://reviewable.io/ Quick comparison from reading the sites of both tools (I have not used any as of now) Review Ninja ------------ * beta version, sponsored by SAP , legalese contract to sign, which does not look quite nice, may not be free for OSS projects * allows to put flags such as [fix] in github review comments which are displayed in the PR status * uses "ninja stars" for approvals. It is possible to configure a minimum number of stars for a PR to become successful, and it seems easy to check who gave a star to a PR * github team integration * notifications can be sent when ninja stars are given * the doc is available and seems clear reviewable.io ------------- * pay for private project, free for OSS model * review done in another app * LGTM button, presumably with reports / notifications * possible to resolve opinion on individual review comments * review messages have a workflow: draft / publish * link to Travis in review tool * can write rules for review completion * nice dashboard * "review me on reviewable.io" button on PR I'm tempted to set up reviewable.io for a couple of repositories, in order to evaluate it. The FAQ warns that mixing github review and reviewable.io review is not optimal: "While comments posted in one will also appear in the other, line comments will turn into top-level comments due to the systems' irreconcilable approaches to line numbering. Also, Reviewable expects that all participants are using its system for tracking unreviewed files and unresolved comments, so if some people are using GitHub those counters probably won't be right." (https://github.com/Reviewable/Reviewable/wiki/FAQ) What do you think? -- Alexandre Fayolle Chef de Projet Tel : +33 4 58 48 20 30 Camptocamp France SAS Savoie Technolac, BP 352 73377 Le Bourget du Lac Cedex http://www.camptocamp.com
Post to: mailto:email@example.com
Unsubscribe: http://odoo-community.org/groups?unsubscribeLaurent Mignon
Senior software engineer
Tel: +352 20 21 10 20 32
Fax: +352 20 21 10 21
Email: firstname.lastname@example.orgAcsone SA, Succursale de Luxembourg22, Zone Industrielle | L-8287 Kehlen, LuxembourgTVA LU24733605 | RCS B160400Acsone sa/nv
Boulevard de la Woluwe 56, b4 Woluwedal | B-1200 Bruxelles - Brussel
RPM Bruxelles 0835.207.216 RPR Brussel--