1. Mailing Lists
  2. Contributors
  3. Re: Should we use the new GitHub reactions?

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

connector_ecommerce dependency in v9

Re: Should we use the new GitHub reactions?

Avatar

Re: Should we use the new GitHub reactions?

by
Holger Brunn
- 17/03/2016 16:23:00 
> What Holger meant by github reaction is this new feature:
> https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments
> To answer Holger's question I think we can use them and commiter can
> take them into account. It could help to find quickly which PR is
> ready.
> We could give it a try.

What I mean is that currently, I look at
https://github.com/pulls?q=is%3Aopen+is%3Apr+user%3AOCA+label%3A%22needs+review%22
to see what I'm supposed to review and choose whatever looks interesting
or important.
According to https://help.github.com/articles/searching-issues, there's
no way to slip in also filtering for reaction count. If this is
possible, I'd be all for switching to reactions, then we could have one
bookmark 'can be merged' (same as above, but reaction count >= 3) and
'needs more reviews' (same as above, but reaction count

Reference