Contributors mailing list archives

contributors@odoo-community.org

Re: Should we use the new GitHub reactions?

by
Camptocamp SA, Yannick Vaucher
- 17/03/2016 15:02:55
Yajo,

What Holger meant by github reaction is this new feature:
https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments


To answer Holger's question I think we can use them and commiter can
take them into account. It could help to find quickly which PR is
ready.
We could give it a try.

Cheers,
Yannick Vaucher
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 30
Office: +41 21 619 10 10
http://www.camptocamp.com/


On 16 March 2016 at 09:22, Yajo <yajo.sk8@gmail.com> wrote:
>
> 2016-03-15 20:38 GMT+01:00 Salton Massally <smassally@idtlabs.sl>:
>>
>> I think he means a dashboard via which you can see only PRs with above 3+
>
>
>
> I don't think such thing exists.
>
>
> 2016-03-11 10:13 GMT+01:00 Yajo <yajo.sk8@gmail.com>:
>>
>> However I don't know how/if GH notifies the participants about reactions,
>> so maybe you still prefer the old add a comment behavior for approvals... In
>> such case, it could be also specified in the guidelines to avoid mistakes by
>> casual reviewers.
>
>
> After trying, you don't get notifications, so IMHO it's better to add a
> comment, or reviewers may have to review the PR all the time to know if it
> should be merged.
>
> Right now I have 43 open PR, I cannot review all of them to see if there are
> new +1s, and I don't only review mines...
>
> _______________________________________________
> Mailing-List: http://odoo-community.org/groups/contributors-15
> Post to: mailto:contributors@odoo-community.org
> Unsubscribe: http://odoo-community.org/groups?unsubscribe