Contributors mailing list archives
Re: v9 migrationby
Tecnativa. S. L., Pedro M. Baeza
OK, if PSC decides so, you can delete the 9.0 branch, and run https://github.com/OCA/maintainer-tools/blob/master/tools/migrate_branch.py to make again the 9.0 clone from 8.0 if you want, but I think that should be the exception, not the rule, or at least, proceed that way.Regards.
2015-11-23 20:23 GMT+01:00 Raphaël Valyi <email@example.com>:
Pedro,I'm not telling it is mandatory to do that.But what if a PSC take the iniative to do it right now before v9 PR's arrive?I'm thinking about the project we admin like account-fiscal-rules and l10n-brazil specifically were 9.0 branches we extracted with only half the modules merged in 8.0 (leaving more than half the modules of v9 branch in v7 state).The 8.0 PR's we here since long ago like August 1014 for account-fiscal-rules or June 2015 but the lack of reviewers while I wasn't working normal have been holding them back. Now nearly all modules are properly migrated in 8.0, with 82% of test coverage for account-fiscal-rules and around 70% for l10n-brazil. Can we not do the merge in these repo to make things simpler to review? Or also to mitigate the risk if some random contributor try to migrate a v7 module to v9 instead of starting from v8?On Mon, Nov 23, 2015 at 4:53 PM, <Pedro@pad.odoo-community.org> wrote:The creation of all 9.0 branches was done for avoiding the complications implied to the corresponding PSCs, and to encourage the direct contribution for migrating modules instead of losing time with "administrative tasks". Going back in this in some projects means that some of the contributors/PSC members have to take care of this branch creation and so on in the moment someone wants to make the first contribution, and the lack of homogeneity, needing to expand the wiki to say "If there's a 9.0 branch, do this. If not, do that..." so I don't see that practical.Regards.
The method in the wiki explains a way to extract the differences from v8, and they're different from new commits, so we can just mention that the changes for the migration are from one explicit commit. Maybe GitHub allows to show diff from various commits. If so, we can update the wiki to reflect how to build a link to that diff for reviewing purposes.2015-11-23 15:22 GMT+01:00 Nhomar Hernandez <firstname.lastname@example.org>:On Mon, Nov 23, 2015 at 9:07 AM, Raphaël Valyi <email@example.com> wrote:What do you think? Can the PSC not do that 8.0 merge into 9.0 just like at the 9.0 branch creating before starting the 9.0 migration process?I am agree with this points.Just take care it should be a case-by-case analysis because there are modules that simply will not apply for v9 or there are repositories that have control of such diff do not make sense just because they can be migrated or simply deprecated....But yes I am agreed in general terms..... (the repositories where it do not pply should be discussed with every PSC i think).--