Contributors mailing list archives

contributors@odoo-community.org

Re: Confusion about branch 9.0 in github

by
Camptocamp SA, Guewen Baconnier
- 13/11/2015 09:17:19

On Fri, Nov 13, 2015 at 9:53 AM, Daniel Reis <dgreis@sapo.pt> wrote:
[...]
if the 8.0 evolved in the meanwhile, people porting to 9.0 the diabled 
code in 9.0 will miss thos changes.
They will need to notice that and use some git hacks to get the missing 
changesets, but that's about the same work you need to git extract a 
module from 8.0 to 9.0 if 9.0 branches started out clean.
[...]


Regards
Daniel

In my opinion it was not the worst issue of the __unported__ directory:
When you migrate a module, commits should reflect the changes done for the migration, reviewers should be able to see only the changes made to achieve that. With the __unported__ folder or the rm/add, files are moved and reviewers see the whole files added. One of the biggest problem of the OCA right now IMO is to have enough reviewers, we have to make the reviews easy to do.

+1 for adding a leading disclaimer explaining that modules may have not be migrated yet and that the list is displayed below.