1. Mailing Lists
  2. Contributors
  3. Re: Confusion about branch 9.0 in github

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Confusion about branch 9.0 in github

Re: Confusion about branch 9.0 in github

Avatar

Re: Confusion about branch 9.0 in github

by
Guewen Baconnier
- 13/11/2015 14:51:44
On Fri, Nov 13, 2015 at 2:23 PM, <Pedro@pad.odoo-community.org> wrote:
Guewen, about that, I know your preference of splitting too much the commits. I give you my opinion about that: I think you should document this with code comments, not with commits, because the end result is the code. If you download on the AppStore a module, you don't have this commit history to see what you want to reflect.
 
Please Pedro, a git repository is not an appstore (hopefully).
Code comments and commits comments have not the same purpose. I enjoin you to read http://chris.beams.io/posts/git-commit/ on this subject.
Anyway the content of the commit messages is off-topic, I insist, a migration of a thousand lines addon in one commit is likely to be wrong.
 

Anyway, Eric's method can be extended saying: you can review starting from this commit to acommodate to your commit approach.

Again, putting the burden on the reviewers who will not see the diff of the migration but the whole addon as new lines. We lack reviewers and existing reviewers lack time, we should more worry about that than about users who are confused because they don't read or misread the readme (the point being to improve the readme and not put more burden on reviewers).

 

Reference