Contributors mailing list archives

contributors@odoo-community.org

Re: OCA Coding Standards and recommended IDEs

by
Xpansa Group, Oleg Kuryan
- 16/10/2015 12:19:07
Eric,

Agree. The main idea behind of suggestion - is improving quality and quantity of iterations need to review.
Idea with limitations on supported editors just allows to build and maintain base of snippets for them. For example, for Sublime they already exists, so no big job to review them and correct, if needed to OCA needs. 
Maybe already there are for other Editors (somebody created for personal use and willing to share). 

And yes, that is something that will be good to have under maintainer tools.

///

Best Regards,
Oleg Kuryan

Technical Director, XPANSA Group | ERP, BI, E-commerce, Data Mining and DMS consulting
Xpansa has developed first full Odoo Android App called mERP. Download at https://play.google.com/merp
/// site  : xpansa.com
/// mail  : oleg.kuryan@xpansa.com
/// phone : +375293358638
/// skype : kuryan.oleg

On Fri, Oct 16, 2015 at 3:08 PM, Eric Caudal <eric.caudal@elico-corp.com> wrote:

It could be interesting to provide/share some snipet files in maintainer-tools for example: it would increase the quality of received PR.
I am not in favor of pushing one or another tool

--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APAC
On 10/16/2015 07:38 PM, Yajo wrote:
<blockquote cite="mid:CAHceOEffrMQZ_Tx8BY9fTx-hKoR3-KD0HMzGCmLHGm3ZYUJakQ@mail.gmail.com" type="cite">

2015-10-16 13:23 GMT+02:00 Leonardo Pistone <lpistone@gmail.com>:
I disagree: I don't think we should support / encourage specific IDEs or other tools. These are very personal choices.

Same here. Please don't do it.

As for tools, I agree that we'd need a simple command line wrapper that lints according to the OCA conventions. Then anyone will be able to tell their editor of choice to use it instead of i.e. "flake8".

Everyone is free to use a text editor that has no flake8 support, so adding those checks you say in travis would be wiser IMHO, as it is now with flake8.

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe