Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Reviews
by
Sunflower IT, Tom Blauwendraat
Hi all, For years, OCA has a big problem with unmerged PR's. Also, even if there are 2 reviews then PSC's generally don't respond to merge requests. The answer has always been "let's review more" or "Let's use gitaggregator and so we can use unmerged PR's". But why don't we try something more radical: - Let's write a script to assign "maintainer" role for all modules to the person who committed the oldest/original version of it - If maintainer does not respond to a ping longer than 1 month he loses the maintainer role, which then changes to the default maintainer that is set for the full repo. - Let's require only 1 positive review from now on. After that the maintainer can merge. --> I don't think that having 2 reviewers is always necessary and it also does not prevent bugs from being merged - this happens anyway. I used to have high trust of merged OCA modules but after seeing some quite ugly bugs and incomplete work being merged I am starting to think that maybe the quality of the unmerged stuff is not that bad as compared to what is actually merged. The maintainer can prevent really bad changes from entering, by just closing the PR. Tom
Follow-Ups
-
-
-
-
-
-
-
-
Re: Reviews
byGroupement Régional Alimentaire de Proximité, Sylvain LE GAL- 16/09/2021 14:50:21 - 0 -
-
