Contributors mailing list archives

contributors@odoo-community.org

Avatar

Reviews

by
Sunflower IT, Tom Blauwendraat
- 16/09/2021 13:49:25
Hi all,

For years, OCA has a big problem with unmerged PR's.

Also, even if there are 2 reviews then PSC's generally don't respond to 
merge requests.

The answer has always been "let's review more" or "Let's use 
gitaggregator and so we can use unmerged PR's".

But why don't we try something more radical:

- Let's write a script to assign "maintainer" role for all modules to 
the person who committed the oldest/original version of it

- If maintainer does not respond to a ping longer than 1 month he loses 
the maintainer role, which then changes to the default maintainer that 
is set for the full repo.

- Let's require only 1 positive review from now on. After that the 
maintainer can merge.

--> I don't think that having 2 reviewers is always necessary and it 
also does not prevent bugs from being merged - this happens anyway. I 
used to have high trust of merged OCA modules but after seeing some 
quite ugly bugs and incomplete work being merged I am starting to think 
that maybe the quality of the unmerged stuff is not that bad as compared 
to what is actually merged. The maintainer can prevent really bad 
changes from entering, by just closing the PR.

Tom


Follow-Ups

  • Avatar

    Re: Reviews

    by
    Tecnativa. S. L., Pedro M. Baeza
    - 17/09/2021 12:12:41 - 0
  • Avatar

    Re: Reviews

    by
    Tecnativa. S. L., Jairo Llopis
    - 17/09/2021 11:57:23 - 0
  • Avatar

    Re: Reviews

    by
    Open Source Integrators, Daniel Reis
    - 17/09/2021 10:20:53 - 0
  • Avatar

    Re: Reviews

    by
    Sunflower IT, Tom Blauwendraat
    - 17/09/2021 09:38:14 - 0
  • Avatar

    Re: Reviews

    by
    DEC, Yann Papouin
    - 17/09/2021 08:56:12 - 1
  • Avatar

    Re: Reviews

    by
    Tecnativa. S. L., Jairo Llopis
    - 17/09/2021 08:45:47 - 0
  • Avatar

    Re: Reviews

    by
    Ecosoft Co. Ltd., Kitti Upariphutthiphong
    - 16/09/2021 18:46:00 - 0
  • Avatar

    Re: Reviews

    by
    Groupement Régional Alimentaire de Proximité, Sylvain LE GAL
    - 16/09/2021 14:50:21 - 0
  • Avatar

    Re: Reviews

    by
    Holger Brunn
    - 16/09/2021 14:20:27 - 1
  • Avatar

    Re: Reviews

    by
    Open Source Integrators, Daniel Reis
    - 16/09/2021 14:02:31 - 0