Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Re: OCA/bank-payment-alternative
by
DIXMIT Consulting SLU, Enric Tobella Alomar
Alexis,
You removed all history from 17 and part of 16. Some of the fixes that you made were already done by other people.
I am just analyzing https://github.com/OCA/bank-payment-alternative/pull/5. The same might happen with all other modules of your alternative, but I don't have the energy or time to do it...
Just to start: you didn't rewrite the history. Commits will be lost on next migration (removing people attribution in the next migration, not now...)
We shared with you how to do it here in a non-blocking review (we didn't want to block your job): https://github.com/OCA/bank-payment-alternative/pull/5#pullrequestreview-2931804750
About removing people attribution: I will raise 2 small examples because it takes time to compare.
- https://github.com/OCA/bank-payment/commit/e43d4bc45b1693db6fd95665d47b095334ef267c#diff-9a169df5110d406a72c04ed6f7444122f52423112f5ddb1c2c199e619b35f60a was included directly by your commit https://github.com/OCA/bank-payment-alternative/commit/76f7432fde71daa1d26e8bbed527690cee4e819b
- https://github.com/OCA/bank-payment/commit/1d37132360fae0d8b6d3204e63007862f3325922 was lost. It improved how it was handled the tests but you ignored it...
Do you need more examples?
My recomendation would be: "check the history of branch 17"
Enric Tobella Alomar
CEO & Founder
Reference
-
OCA/bank-payment-alternative
byAlexinux, Alexis de Lattre- 21/06/2025 00:40:10 - 0-
-
-
-
-
-
-
-
-
-
Re: OCA/bank-payment-alternative
byDIXMIT Consulting SLU, Enric Tobella Alomar- 27/06/2025 08:10:08 - 0
-
