1. Mailing Lists
  2. Contributors
  3. Re: OCA/bank-payment-alternative

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: OCA/bank-payment-alternative

Re: OCA/bank-payment-alternative

Avatar

Re: OCA/bank-payment-alternative

by
DIXMIT Consulting SLU, Enric Tobella Alomar
- 26/06/2025 17:10:54
Alexis,

You removed all history from 17 and part of 16. Some of the fixes that you made were already done by other people.

I am just analyzing https://github.com/OCA/bank-payment-alternative/pull/5. The same might happen with all other modules of your alternative, but I don't have the energy or time to do it...

Just to start: you didn't rewrite the history. Commits will be lost on next migration (removing people attribution in the next migration, not now...)

We shared with you how to do it here in a non-blocking review (we didn't want to block your job): https://github.com/OCA/bank-payment-alternative/pull/5#pullrequestreview-2931804750

About removing people attribution: I will raise 2 small examples because it takes time to compare.

- https://github.com/OCA/bank-payment/commit/1d37132360fae0d8b6d3204e63007862f3325922 was lost. It improved how it was handled the tests but you ignored it...

Do you need more examples?

My recomendation would be: "check the history of branch 17"

El lun, 23 jun 2025 a las 23:52, Alexis de Lattre (<notifications@odoo-community.org>) escribió:
Le sam. 21 juin 2025 à 11:47, Pedro M. Baeza <notifications@odoo-community.org> a écrit :
and also not respecting such contributions attribution, which is one of the main principles of the open source.

I agree with you, contribution attribution is very important in free software projects. If there is some code in OCA/bank-payment-alternative that doesn't respect contribution attribution please report it and we'll fix it.

--
Alexis de Lattre

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
Enric Tobella Alomar
CEO & Founder

Reference