1. Mailing Lists
  2. Contributors
  3. Re: The future of oca/bank-payment

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: The future of oca/bank-payment

Re: The future of oca/bank-payment

Avatar

Re: The future of oca/bank-payment

by
MoaHub, Graeme Gellatly
- 16/04/2025 11:06:20
Just ping me if you need review, unfortunately we get failure trying to test locally, but we are in the middle of a 450 module migration, down to last dozen or so, most ultimately depending on payment order. We have production data, freshly migrated via enterprise to do real proper testing on. Only problem we face is we can't aggregate the current merge requests.  Although maybe there is a better way we can do that.

merges:
    - origin $ODOO_VERSION
    # Can't merge 1439 at the moment because of this
    # test-requirements.txt commit:
    # befd64bd07aaa293026b648bc06494d6f1b466fc
    #- origin refs/pull/1438/head # 'account_payment_mode'
    #- origin refs/pull/1439/head # 'account_payment_partner'
    #- origin refs/pull/1440/head # 'account_payment_order'

On Wed, Apr 16, 2025 at 7:22 PM Pedro M. Baeza <notifications@odoo-community.org> wrote:
I'm disappointed that both Virginie's summary and Alexis' reply appears to say "Alexis' proposal is better, but...", when I exposed clearly in the meeting and previously written on the threads that the main problems are:

- The switch to account.payment.method.line is not better. It provokes a lot of work to do, user adaptation, etc, with no clear benefit.
- The current proposed code starts from a fork done 2 years ago, not having all the work done meanwhile in the main branch.
- It contains a lot of datamodel changes apart from the main question, which are the same problematic.

And again, I'm not saying the current code quality on the XML export is the best, but that it should be worked on as a separate proposal, not trying to impose all the changes together. I even offered to help him to extract that improvement to be proposed over current OCA code, but my offering seems to not serve for anything...

I'm also surprised about the washing done on Alexis' attitude, while he clearly recognized it.

Anyway, I continue with the merging of the current modules that is blocking me and a lot of other good contributors, and I have already spent a lot of time on this topic.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference