1. Mailing Lists
  2. Contributors
  3. Re: Tests failure when invoicing is involved after a change in Odoo upstream

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Tests failure when invoicing is involved after a change in Odoo upstream

Re: Tests failure when invoicing is involved after a change in Odoo upstream

Avatar

Re: Tests failure when invoicing is involved after a change in Odoo upstream

by
Acsone SA/NV, Stéphane Bidoul
- 12/03/2025 16:08:54
While fixing the 16.0 branch for l10n_belgium I have done some more research on this.

In 16.0, something like `odoo -i l10n_be` gives you two companies with main company without CoA (that's the problem mentioned in OP)

- Your Company (base.main_company), country=US, no CoA
- BE Company, country=BE, BE CoA

In 17.0 and 18.0, the generic CoA is loaded on main_company even though a localization was loaded:

- Your Company (base.main_company), country=US, Generic CoA
- BE Company, country=BE, BE CoA

This is why we only see the problem in 16.

So I now think pre-loading l10n_generic_coa before running the tests in 16.0 is an easy fix, and also a good solution (and the one I prefer), because it sets up the main company identically to what we get in later versions.

IMO, tests that really depend on a CoA should use a company initialized with that CoA, and not base.main_company.

This is what I did in l10n_belgium: https://github.com/OCA/l10n-belgium/pull/243

Best regards,

-Stéphane

On Fri, Feb 28, 2025 at 7:33 PM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
I have hit this issue in one of my projects where I run all tests post-install.

Instead of changing all my tests, I chose to install l10n_generic_coa in CI, which was an easy solution in my specific situation.
Maybe this can help others hitting the same problem.

Best regards,

-Stéphane


On Wed, Feb 26, 2025 at 4:53 PM Pedro M. Baeza <notifications@odoo-community.org> wrote:
Stefan and Denis, the reason for the Odoo patch may be legit, and it is. The problem is that it comes too late for the lifecycle of this version IMO, and more having in version 17 integrated the generic CoA into account for better practices. Anyway, this is just undisclosing a problem that has been hidden in the design of our OCA tests, them not being deterministic and really unit tests, as they are relying on previous state of data for being successful:

- The company used is the one populated by default instead of using a full set of data including the company. This may be reasonable for execution times, and that's why the decision to just fix this condition installing an existing CoA instead of populating on each test a new company.
- There's no guarantee a CoA is loaded at the time of performing the tests, but creating an invoice requires it. That's why the post-install thing (and it's also a requirement if inheriting AccountTestInvoicingCommon).


Inheriting from AccountTestInvoicingCommon, as explained in the commit message I linked in my first message, it's not improving the thing (at least in 16, in 17 it's more ironized), because it still requires `l10n_generic_coa` installed (and installed before the execution of this test), and its setup is very heavy, creating 2 companies (even if you only require one), so this would increase the test execution times a lot in the best case, or skipped without you really noticing in the worst (when generic CoA is not available).

The added code is NOT boilerplate. It's legit code for making deterministic tests, the same as you may remove currency rates for having a deterministic environment. And it's totally harmless if you don't need it, because starting with, it's in test code, not in business code, and if you keep the previous status quo, the if it's not executed, so it doesn't affect any previous condition. This can only uncover other hidden defects on the modules being executed in post-install, and this is being patched at the same time.

Replying to other threads answers, I don't think this will reverted, as AFAIK Odoo.sh is auto-installing the modules that hides the problem, and not installing any localization module, but I'm not expert of that platform, so I may be wrong.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference