1. Mailing Lists
  2. Contributors
  3. Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Odoo Experience 2025 - OCA Zone

Re: Odoo Experience 2025 - OCA Zone

Avatar

Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

by
Datenbetrieb Technologie UGh, Peter Niederlag
- 22/02/2025 12:40:28 
Hi,

thx for putting that much work into analysis and sharing your findings.

Do we have a proper link to the upstream issue?

cheers,
Peter

On 21.02.25 13:47, Thorsten Vocks wrote:

> Hello,

> 

> approx. 7 days ago we have detected a critical issue regarding the 

> fiscal position assignation for setups with installed german 

> localisation (*l10n_de*). Obviously all databases created / last updated 

> approx. 20th October are affected.

> 

> *At first we thought version 18.0 is not affected but that was wrong.*

> 

> Here is the video with a manual fix of the fiscal positions:

> 

> https://drive.google.com/file/d/1NY32FeGzALr8e-IpN9ojKlQGwe38ksAy/view 

> <https://drive.google.com/file/d/1NY32FeGzALr8e-IpN9ojKlQGwe38ksAy/view>

> 

> *At Odoo SA we have a open bug report but no response so far:*

> 

> Issue Type: Critical Bug

> 

> Module: Accounting / German Localization

> 

> Odoo Versions: [16.0, 17.0]

> 

> *Also affected is [18.0]*

> 

> Impacted Environment:

> 

> * Both

> ** Not affected is 17.04., 18.0*

> 

> 

> *Summary:*

> 

> The fiscal position is being incorrectly assigned to partners in the 

> German localization (German B2B partners with Vat-ID assigned). This 

> leads to incorrect tax calculations and potential legal compliance 

> issues for users relying on automated fiscal position determination.

> 

> 

> *Steps to Reproduce:*

> 

> 1. Configure the German localization module.

> 2. Create a new partner with an address located in Germany.

> 3. Assign a VAT ID to the partner.

> 4. Create a sales order or invoice for the partner.

> 5. Observe the fiscal position that gets assigned automatically (wrong).

> 

> *Expected Behavior:*

> 

> * The fiscal position should be assigned based on the VAT ID, address, 

> and configured fiscal rules.

> * The correct tax rates and exemptions should be applied in accordance 

> with German tax regulations.

> 

> 

> *Observed Behavior:*

> 

> * The fiscal position is either not assigned correctly or does not 

> reflect the expected tax rules.

> * Especially B2B partners receive an incorrect fiscal position, leading 

> to incorrect tax calculations.

> * This can result in non-compliance with German tax regulations and 

> incorrect tax reporting.

> 

> 

> *Impact:*

> 

> * Financial discrepancies due to incorrect tax application.

> * Compliance risks with German tax authorities.

> * Increased manual corrections required by users.

> 

> *Suggested Fix:*

> 

> * Review and correct the fiscal position assignment logic in the German 

> localization module.

> * Ensure that VAT IDs and partner addresses are properly considered when 

> determining fiscal positions.

> * Implement additional validation checks to avoid incorrect fiscal 

> position assignments.

> * I have proposed a quick fix solution in my video.

> 

> *Video:*

> 

> *

> *https://drive.google.com/file/d/1NY32FeGzALr8e-IpN9ojKlQGwe38ksAy/view 

> <https://drive.google.com/file/d/1NY32FeGzALr8e-IpN9ojKlQGwe38ksAy/view>

> 

> 

> *Priority: *

> 

> Critical

> 

> *Additional Notes:*

> 

> *

> ** This issue was observed in trainings for our customers.

> * All customers running on v16, v17, *v18 *in Odoo are effected (except 

> they assign fixed fiscal positions to partners, which happens in some 

> rare cases).

> * Affected users have reported increased manual workload due to 

> incorrect assignments.

> * Maybe they have created wrong account moves. Due to audit_trail we 

> cannot fix that easily.

> * We have to investigate this now on all customer databases (german 

> companies).

> * We strongly recommend you to warn other german customers working on a 

> v16, v17, *v18* version.

> 

> 

> Thorsten Vocks

> 

> openBIG.org

> Dipl. Kaufmann (FH)

> Porscheweg 4-6

> 49661 Cloppenburg

> 

> Phone: +49 4471 8409000

> Fax: +49 4471 84090009

> Mail: thorsten.vocks@openbig.org <mailto:thorsten.vocks@openbig.org>

> Web: http://www.openbig.org <http://www.openbig.org>

> 

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 

> <https://odoo-community.org/groups/contributors-15>

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

> <https://odoo-community.org/groups?unsubscribe>

> 

mit freundlichen Grüßen,
Peter Niederlag

-- 
Dipl. Ökonom Peter Niederlag
Geschäftsführender Gesellschafter

Lösungen für digitale Zeiten
Agile DevOps, Cloud, TYPO3, Odoo und Linux

Datenbetrieb Technologie UG(haftungsbeschränkt)
Lipper Hellweg 146,  33605 Bielefeld
Geschäftsführer: Peter Niederlag
HRB 41826 Amtsgericht Bielefeld
Fon 0521 / 446 958 60
Fax 0521 / 446 958 69

Reference