1. Mailing Lists
  2. Contributors
  3. Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

Avatar

Re: Critical Fiscal Position Assignation Issue (only Germany) - 16.0 17.0 18.0

by
OpenBig, Thorsten Vocks
- 21/02/2025 17:34:31
Hallo Frederik,

This revert

https://github.com/odoo/odoo/commit/af3a24c010d3e7158c1324f36a1529c510d886a6

and this original commit

https://github.com/odoo/odoo/commit/bcaf8cb859dc2f7e975d180ba0fc49da20204557

introduced and reverted the problematic code if i am not mistaken. I didn't review the code duely, but afais that the problematic code should only be in databases / data that have been created between

24th of September 2024 and 25th of October 2024

That means customers with versions of Odoo 16, 17 and 18 that either updated their code in that time frame or installed new databases should be affected. Others hopefully not!



Unfortunately not.
I could recapture that today on Odoo runbot v18.
Last week on v16, v17 (current runbot versions).
And all my other testing was also databases on odoo runbot.

I guess the revert didn't fix the introduced problem.
Honestly i am not 100% sure which exact commit introduced 
the issue.

 
Best regards
Thorsten


Best and thanks for circulating this

Frederik

Am 21.02.25 um 13:47 schrieb Thorsten Vocks:
Hello,

approx. 7 days ago we have detected a critical issue regarding the fiscal position assignation for setups with installed german localisation (l10n_de). Obviously all databases created / last updated approx. 20th October are affected.

At first we thought version 18.0 is not affected but that was wrong.

Here is the video with a manual fix of the fiscal positions:

At Odoo SA we have a open bug report but no response so far:

Issue Type: Critical Bug

Module: Accounting / German Localization

Odoo Versions: [16.0, 17.0]

Also affected is [18.0]

Impacted Environment:

* Both
* Not affected is 17.04., 18.0


Summary:

The fiscal position is being incorrectly assigned to partners in the German localization (German B2B partners with Vat-ID assigned). This leads to incorrect tax calculations and potential legal compliance issues for users relying on automated fiscal position determination.


Steps to Reproduce:

1. Configure the German localization module.
2. Create a new partner with an address located in Germany.
3. Assign a VAT ID to the partner.
4. Create a sales order or invoice for the partner.
5. Observe the fiscal position that gets assigned automatically (wrong).

Expected Behavior:

* The fiscal position should be assigned based on the VAT ID, address, and configured fiscal rules.
* The correct tax rates and exemptions should be applied in accordance with German tax regulations.


Observed Behavior:

* The fiscal position is either not assigned correctly or does not reflect the expected tax rules.
* Especially B2B partners receive an incorrect fiscal position, leading to incorrect tax calculations.
* This can result in non-compliance with German tax regulations and incorrect tax reporting.


Impact:

* Financial discrepancies due to incorrect tax application.
* Compliance risks with German tax authorities.
* Increased manual corrections required by users.

Suggested Fix:

* Review and correct the fiscal position assignment logic in the German localization module.
* Ensure that VAT IDs and partner addresses are properly considered when determining fiscal positions.
* Implement additional validation checks to avoid incorrect fiscal position assignments.
* I have proposed a quick fix solution in my video.

Video:


https://drive.google.com/file/d/1NY32FeGzALr8e-IpN9ojKlQGwe38ksAy/view


Priority: 

Critical

Additional Notes:


* This issue was observed in trainings for our customers.
* All customers running on v16, v17, v18 in Odoo are effected (except they assign fixed fiscal positions to partners, which happens in some rare cases).
* Affected users have reported increased manual workload due to incorrect assignments.
* Maybe they have created wrong account moves. Due to audit_trail we cannot fix that easily.
* We have to investigate this now on all customer databases (german companies).
* We strongly recommend you to warn other german customers working on a v16, v17, v18 version.


Thorsten Vocks

openBIG.org
Dipl. Kaufmann (FH)
Porscheweg 4-6
49661 Cloppenburg

Phone: +49 4471 8409000
Fax: +49 4471 84090009
Mail: thorsten.vocks@openbig.org

              

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

-- 
Dr.-Ing. Frederik Kramer
Geschäftsführer

initOS GmbH
Innungsstraße 7
21244 Buchholz i.d.N.

Tel:   +49 (0) 4181 13503 12
Fax:   +49 (0) 4181 13503 10
Mobil: +49 (0) 179 3901819

Email: frederik.kramer@initos.com
Internet: www.initos.com

Geschäftsführung:
Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke

Sitz der Gesellschaft: Buchholz i.d.N.
Amtsgericht Tostedt, HRB 205226
USt-IdNr.: DE815580155
Steuer-Nr: 15/200/53247

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference