1. Mailing Lists
  2. Contributors
  3. Re: pandoc-*.deb cleaning in OCA repositories

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: pandoc-*.deb cleaning in OCA repositories

Re: pandoc-*.deb cleaning in OCA repositories

Avatar

Re: pandoc-*.deb cleaning in OCA repositories

by
MetricWise, Inc., Adam Heinz
- 05/08/2024 14:39:26
Add a note to the migration documentation to delete the large files commit? There is already a process to merge translation commits together during migration and this seems like a similar amount of difficulty.

On Mon, Aug 5, 2024 at 8:32 AM Enric Tobella Alomar <notifications@odoo-community.org> wrote:
The problem is that this files and changes will be imported on future migration PRs on future branches (some files are inside the module folder). This is a decision that will impact the future of all OCA users. So this is something that will not disappear with time. Letting it go because we think it will disappear is a mistake.

Change nothing is the easiest choice but we all know that this will not disappear and is a bad choice. We also are discussing this, but I think that there is not so many repositories affected.

On Mon, 5 Aug 2024, 12:17 Jairo Llopis, <notifications@odoo-community.org> wrote:
El vie,  2 de ago de 2024 a las 12:52:18 P. M., Enric Tobella Alomar <notifications@odoo-community.org> escribió:
I think the benefits are bigger than the cons

I think the opposite.

Benefits:
  1. Save disk space in case you're either not cloning with --depth 1, or you're going to do a git gc after all the manual work that will mean updating all your local clones.
  2. Save bandwith space under similar conditions.
Potential problems:
  1. Break your lock files.
  2. Need to rebase almost every open PR against those branches.
  3. Inclusion of unwanted commits (that include those wonderful 30MB files) in more PRs.
  4. Disturbing many developers.
  5. Making oca-port unable to detect relationship between commits and PRs.
  6. Manual work involving the repo admins and almost all OCA developers.
  7. Things I don't imagine right now.
Definitely not worth it. One day we'll stop using those branches (hopefully in about 3-5 years) and we won't care about those few extra MBs.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference