Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: Proposing myself, David BEAL, for EDI PSC

by
Akretion France, David BEAL
- 29/06/2020 14:00:59
Hi,

Thanks a lot Simone and congratulations for your new child ;-)

This is the first time I'm PSC then I discover these super powers.

In that particular case of EDI repo, there is just 2 PSC displayed
(somebody probably escaped from here)
https://odoo-community.org/psc-teams/edi-109
It seems I can approve and merge PR of other contributors but I now I
have a real problem with my own PR.

Here https://github.com/OCA/edi/pull/211
even If I have 2 approved on this trivial PR my super power can't
allow me to merge it.

Github display "At least 1 approving review is required by reviewers
with write access."
It's a setting I never see in other repo: elsewhere 2 approval from
anybody are sufficient to be merged by PSC
Am I wrong ?

These super powers seem more related to robin ones than batman ones.
And I saw no car in the headquarter.

My colleague as PSC is very, very, very, very busy and only has 1% of
the time that I need for my own PR reviews.

Yes, a really difficult mission here with a lot of waste of time (many
times) for me, probably really more than before.
Is there a more complete list of oca's guys with adhoc rights for review ?
I don't know which added value I can bring to this repo if I can't
merge approved and reviewed (including by myself).

It's very strange to me.

Regards


David BEAL - akretion.com
Chef de projet
Odoo Développement / Intégration

Le dim. 28 juin 2020 à 08:52, Simone Orsi <simahawk@gmail.com> a écrit :

>

> Hi David,

>

> you are in. Can you check?

>

> Cheers,

> S.

>

> On Fri, Jun 26, 2020 at 10:02 AM David Beal <david.beal@akretion.com> wrote:

>

> Hi all,

>

> I'll ask you to become PSC for EDI repository

>

> https://github.com/OCA/edi/pulls?q=is%3Apr+author%3Abealdav+sort%3Aupdated-desc+

>

> https://github.com/bealdav

>

> Thanks a lot for considering it.

>

> Regards

>

>

> David BEAL - akretion.com

> Chef de projet

> Odoo Développement / Intégration

>

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe

>

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference