Contributors mailing list archives
Re: Yet another followup module ?by
Open for Small Business, Graeme Gellatly
Evolution vs revolution. Only 1 can be done easily inside OCA for a non original contributor. Indeed I imagine that is the genesis of the 1 module rule, to support evolution and discourage revolution.
So when you disagree with a long established and regularly migrated module, I wholeheartedly agree with Alexis approach.
Do it, then worry about the rest later.
I support the rule, but I'm aware it is a tradeoff between 2 approaches.
On Wed, 22 Apr 2020, 10:42 pm Roussel, Denis, <email@example.com> wrote:
Great!But one question comes into my mind.Why not having proposed a refactor of existing module to split functionalities in different modules in order to allow user choosing the ones he wants to use ?On Wed, Apr 22, 2020 at 12:22 PM Alexis de Lattre <firstname.lastname@example.org> wrote:Dear OCA friends,I published yesterday a new module called Overdue Invoice Reminder (technical name : account_invoice_overdue_reminder) :It is an alternative to the OCA module account_credit_control available on https://github.com/OCA/credit-control (was in OCA/account-financial-tools for v10 and under)If you want to have a demo of my new module, please look at my screencast :Why did I decide to develop "yet another module" for followup ? Because I deployed the account_credit_control module for several companies (in v10), and the experience was not very positive, and they all stopped using it shortly after the deployment. My feeling about this OCA module is that it is like an army tank designed to send millions of followup letters ; the usability is not so good and it's not possible to customize the email/letters. Also, this module is very big (1900 line of python code) and difficult to modify because it is quite complex. That's why I decided to start the development of a new module from scratch. My main goals were:- give full control on the overdue email/letters to the user,- usability and easy the understand,- simplicity (700 lines of Python code, easy to read and understand),- reminders by email by default, with the possibility to also send letters and make phone calls.Please look at the README of the module for more info about the module (and its limitations) :I haven't submitted this module to OCA because of the rule "1 module per feature". But, if you think that this module should be in OCA, I'm ready to submit it. Anyway, your feedback on this module is welcomed. But don't forget that I want to KEEP THIS MODULE SIMPLE, so I may refuse features that add too much complexity.P.S. : I plan to backport this module to v10 after the first feedbacks.
Acsone SA, Succursale de Liège (Val Benoît)
Tel : +32 2 888 31 49
Fax : +32 2 888 31 59
Gsm : +32 472 22 34 64Acsone sa/nv
Boulevard de la Woluwe 56 Woluwedal | B-1200 Brussels | BelgiumQuai Banning, 6 (Val Benoît) | B-4000 Liège | Belgium
Zone Industrielle 22 | L-8287 Kehlen | Luxembourg