Contributors mailing list archives
Re: Stale PR closingby Alexey Pelykh <firstname.lastname@example.org> - 19/09/2019 09:55:28
- There was no review at all, or not enough reviews. It’s very unfortunate, but it still makes a PR stale. And this should be somehow addressed by bot as well, e.g. calling for reviewers after 3 months and if no-one was interested - well, it is what it is?
- There were reviews that were not addressed - this one can just be closed as abandoned by author.
On Sep 19, 2019, at 10:41, Graeme Gellatly <email@example.com> wrote:You misread it by not checking the section it was under. Can be closed if no activity in response to the review. You can't just arbitrarily close an unreviewed PR. There is a big discussion somewhere where that was agreed, but it was years ago now.On Thu, Sep 19, 2019 at 8:02 PM Alexey Pelykh <firstname.lastname@example.org> wrote:By the way, according to https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst it’s 6 months and no questions asked :)
On Aug 29, 2019, at 18:16, Stéphane Bidoul <email@example.com> wrote:I'm in favor to move forward with this.Alexey was kind enough to do a PR, which includes adding a "stale 🗃" label so they are easy to find.Note PR merged by /ocabot merge (virtually all of them these days) are labeled as "merged 🎉" so they too are easy to find even in case a rebase has been done.12 months is a reasonably long time. And if anyone is still interested it's easy to (ask to) reopen to get a new one year lease.@Graeme Gellatly does this address your concerns?-sbiOn Thu, Aug 29, 2019 at 6:27 PM Alexey Pelykh <firstname.lastname@example.org> wrote:We can implement just-labeling initially, at least to see the amount of impact. Personally, I don’t see any harm in closing PR that had 0 comments for 12 months, assuming it’s valuable and reviewers are doing their part of the deal.
On Aug 29, 2019, at 18:17, Joël Grand-Guillaume <email@example.com> wrote:For your case @Graeme Gellatly may be we can just add a label "Close by bot" so it's still pretty easy to find them right ?Because today, the fact so many PRs remain open for months if not years is a real issue I think.Any how, we all agree there is something to do here. The OCA days is probably the best place to discuss it right ;)On Thu, Aug 29, 2019 at 2:36 PM Daniel Reis <firstname.lastname@example.org> wrote:If we do this, we need to make sure that closed PR really means that the PR was not merged.I see on the Odoo repo may closed PRs that had their code manually merged - not sure if we have this in the OCA.What if the bot just regularly (monthly?) pinged the followers.People would manually close a stale PR if that makes sense.Daniel
No dia 29/08/2019, às 12:12, Kitti Upariphutthiphong <email@example.com> escreveu:Or once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <firstname.lastname@example.org> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months after
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario.El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<email@example.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <firstname.lastname@example.org> wrote:
+1 18 months
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <email@example.com> wrote:
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <firstname.lastname@example.org> wrote:Dear community,In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?Kind regards,Alexey
Post to: mailto:email@example.com