1. Mailing Lists
  2. web
  3. Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

web mailing list archives

web@odoo-community.org

Browse archives

Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

Avatar

Re: [OCA/web] [12.0][MIG] web_widget_digitized_signature (#1325)

by Maxime Chambreuil <notifications@github.com> - 18/07/2019 15:34:06

Hi @rafaelbn,

The changes I pushed are cosmetic changes to facilitate code readibility and have consistency:

  • Having double quote and single quote in the same manifest doesn't make sense to me.
  • Having XML file with 120+ characters line either.

I don't see the point of doing separate pull requests of the same module for that and asking people to review this separately. Let's not waste everyone else time on this. Especially when we ask people later to squash commits...

Also this is a Tecnativa module that we decided to maintain, so give me a break. If you wanted to take care of it and maintain it, you had plenty of time to provide an alternative maintainer.

I think we discussed it long enough last year, this kind of behavior is negative for the community. We should welcome contributions and improve them, not reject them.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.