Sorrento code sprint mailing list archives


Re: wrap-up code from the sprint

Acsone SA/NV, Stéphane Bidoul
- 25/05/2016 17:03:00
I'm not so much in favor of merging a bunch of disabled code if nobody is volunteering to look after it.

BTW, why don't we do smaller modules (ledger, etc) with one meta-module that pulls all the OCA reports?


On Wed, May 25, 2016 at 3:51 PM, Leonardo Pistone <> wrote:
Thanks for your feedback.

About the module account_financial_report_qweb, it is difficult to
extract only the general ledger without completely messing up the
branch for other parts when they will be merged at a later time.

What I could do is: I could "git filter-branch" to extract everything
that was done on account_financial_record_qweb. If some reports are
really unfinished or broken, I could leave them in but disabled (for
example I could comment out the menuitem). I will add an explanation
of the README. I will fix problems "on the surface" like lint in the
module, too.

This is the "feature flags" approach and I think it can work well here
because we can hide unfinished reports easily. I think this should
make it easier for people to make subsequent pull requests to activate

What do you think?

On Tue, May 24, 2016 at 6:11 PM, Jordi Ballester Alomar
<> wrote:
> Hi Leonardo,
> Last week I was working on the account_financial_report_qweb module, and I
> created a separate branch:
> The work is still in progress, but it is starting to take shape.
> I'd like to keep that one.
> Regards,
> Jordi.
> On Tue, May 24, 2016 at 12:01 PM, Leonardo Pistone
> <> wrote:
>> Hi all!
>> I am trying to wrap up and get our code reviewed and merged.
>> Some of the work, including date_range and mis_builder is already
>> merged, which is great!
>> I am now trying to clean up the push-here branch. I think I should
>> make a rebase of it to remove things which are already in other pull
>> requests, like the mis builder. I think I will try the rebase in a new
>> branch containing only the account_financial_report_qweb module, and
>> propose that one to OCA/account-financial-reporting. What do you
>> think?
>> Before doing that, please check:
>> - do you have any code you would like to push to push-here before I
>> rebase? It would be easier to do it now than later
>> - Do you have code you would like to keep in the other branches of
>> oca-sorrento? If so, what would you like to do with it? If you find
>> duplicated or otherwise useless branches of yours in oca-sorrento,
>> please delete them.
>> Thanks to all for your work! Let me know if you have any ideas for this.
>> Leo
>> _______________________________________________
>> Mailing-List:
> --
> Jordi Ballester Alomar
> CEO & Founder | Eficent
> (+34) 629530707 | |
> Twitter: | Linkedin:
> _______________________________________________
> Mailing-List:
> Post to:
> Unsubscribe:

Post to: