Project and Services mailing list archives

project@odoo-community.org

Avatar

Re: [OCA/project] project_task_scheduling: Module for automatic task planning (#419)

by Alexey Pelykh <notifications@github.com> - 11/12/2018 16:44:02

@alexey-pelykh requested changes on this pull request.


In project_task_employee/models/project.py:

> @@ -0,0 +1,12 @@
+# Copyright 2018 Tecnativa - Ernesto Tejeda
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import fields, models
+
+
+class ProjectProject(models.Model):
+    _inherit = 'project.project'
+
+    employee_ids = fields.Many2many(

Shouldn't we link to res.users here instead? Since https://github.com/odoo/odoo/blob/7e5d5045bfa7752176dd8f19c546ff6b19841381/addons/project/models/project.py#L439


In project_task_employee/tests/__init__.py:

> @@ -0,0 +1,2 @@
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+from . import test_project_task

Please add newline


In project_task_employee/tests/test_project_task.py:

> @@ -0,0 +1,41 @@
+# Copyright 2018 Tecnativa - Ernesto Tejeda
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo.tests.common import TransactionCase

Newline would be great


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.