Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: Migration to version 9

by
Open for Small Business, Graeme Gellatly
- 27/08/2015 12:57:40

Pedro is right,  they play havoc those init files and openerp files even if installable is false.  Especially if you are lazy and copy a module and just set installable false.

Sent from TypeMail

On 28 Aug 2015, at 12:53 AM, Bidoul@pad.odoo-community.org wrote:
On Thu, Aug 27, 2015 at 11:37 AM, <Pedro@pad.odoo-community.org> wrote:
Letting the modules on top dir isn't an option too because some reasons that are already said and some more that I summarize here:
  • It confuses users about what modules are available.
This can easily be solved by showing the list of modules and their status in the repo README.md.
On the contrary I see value to have unported module at the top level: it is easier to discover existing modules that just need to be ported.
  • It loads __init__.py files, which can lead to lot of initial broken branches.
Does it load __init__.py if installable = False? I don't think so but I'd need to check. In any case, apps.odoo.com ignores modules with isntallable = False.
  • There are modules that are deprecated.
These must be removed. 
  • It doesn't help to recognize which ones are ported.
That's the same as above. 

So I think the proposed solution is less bad. I think that we can also workaround easily the "merge question" tagging 8.0 branches when we make the split, and making `git rebase ^<tag>`, but let me check if it can be. Rebase is not the same as merge, but I even prefer this option in most times. What do you think about this, Stephane?

That's to be tested. I have doubts. AFAIC, git merge is an important and very useful and easy part of my git workflow. It's also well understood by most.
I'm getting in touch with Odoo to understand what their merge process is. There is proably inspiration to be gotten there.

Cheers,

-sbi

_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe

Reference