Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: Migration to version 9

by
Tecnativa. S. L., Pedro M. Baeza
- 26/08/2015 20:28:05
Stephane, I'm not a fan to make git merge over branches in general, so I don't agree with you that it's a big con. A cleaner and less painful process to apply a patch over versions is to cherry-pick corresponding commit (and thanks to merge commits, you also can apply only one for each PR).

Regards.

2015-08-26 20:23 GMT+02:00 <Bidoul@pad.odoo-community.org>:
Another big con is that the forward port process by a git merge of 8.0 into 9.0 is not possible.

I'll think to it a little bit more but I'd say at this stage I'm not a huge fan of this method. I believe the disadvantages outweight the small benefit of hiding unported modules.

At some point there was a proposal of 
- keeping unported modules with active=False
- having an (autogenerated) list of modules and their status in the README.md of the repository

That proposal plus an systematic forward port process is my favorite approach at this point.

-sbi

On Wed, Aug 26, 2015 at 7:52 PM, <Pedro@pad.odoo-community.org> wrote:
Pros of this method:
  • Avoid a lot of commits starting the branch.
  • Avoid commits of deprecated modules.
  • Avoid having outdated version that was put on __unported__ when release version was out, but later modified on the previous version.
  • Avoid forgetting to use the version in __unported__.
  • No misunderstanding for newcomers about the existence of the module in the __unported__ folder.
  • No need to remove any module.

Cons of this method:

  • It requires a process to start a PR a bit more complicated than before.
  • Reviewers should check if the commit history is well-extracted.
  • Contribution statistics are disturbed by this process (although it can be easily filtered by distinct commits).

So we think the number of pros is better than the cons, and that's why we propose this.

Please comment any possible thing we haven't figure out.

Regards.

 

2015-08-26 19:23 GMT+02:00 Maxime Chambreuil <maxime.chambreuil@savoirfairelinux.com>:
Dear OCA contributors

Pedro and I proposed a new process to manage the coming migration from 8 to 9 :

Main thing is to get rid of the __unported__ directory as it contains outdated versions of modules. We want to migrate the latest version and avoid duplicating PR against many branches.

Version 9 is still more than a month ahead, so we have time to review, discuss and agree on this proposal.

Cheers,
--
Maxime Chambreuil
+1 (514) 276-5468 #126

_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


Reference