Contributors mailing list archives

Browse archives


Re: Self-merging rule

Serpent Consulting Services
- 26/08/2015 10:42:45
Hard to decide which way!

Sometimes, based on the workload of PRs, one might need to self-merge!

OCA guys are finding their own time from their work. Sometimes, localizations are not everyone's understanding.

As a whole, travis helps better to check all kinds and functionally, the Merger has to be sure of.


On Wed, Aug 26, 2015 at 2:08 PM, Joël Grand-Guillaume <> wrote:
+1 to not allow self-merging.

This should be the rule everybody respect. Moreover that's a common rule in all open source ecosystem/project and for good reasons.

Now, If a core maintainer do it for good reasons (typo fix, little nits, etc..) that's alright, but that must remain the exception, not ther ule.



On Tue, Aug 25, 2015 at 9:08 AM, Daniel Reis <> wrote:
+1 for not self-merging

I've also been asked to not do it, I've avoided it since then, and think 
it works well.
Merging is a last checkpoint, and should be done by an independent 
There are many people with write access, adding a comment asking for it 
to be merged is not an issue.


Às 13:22 de 23/08/2015, Pedro Manuel Baeza Romero escreveu:
> Hi all,
> I faced some days ago a complaint from Stefan Rijnhart about myself 
> merging one of my PRS when the number of approvals was the appropiate. 
> This is an old OCA rule that was applied on old Launchpad times.
> This rule is not even in the current OCA contributing guidelines 
> (, 
> but he insists on bringing this topic to the mailing list.
> I see no special reason to apply again this rule nowadays, because 
> thanks to the merge button, the task doesn't involve any special risk 
> to screw up things. In Launchpad, there was this risk, as the merge 
> implies some manual operations that can lead to a bad merging, but as 
> I said, today this is not a problem.
> What the others think about this rule?
> Regards.
> _______________________________________________
> Mailing-List:

Post to:



Joël Grand-Guillaume
Division Manager
Business Solutions

+41 21 619 10 28

Post to:

The Splendid journey of 2 years in Numbers
Jay Vora,
Managing Director,
<img src="" style="color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">
Serpent Consulting Services Pvt. Ltd.
Web :
Mobile : 91 - 9879354457
Twitter: jaynvora
Skype: jaynvora
Blog :