1. Mailing Lists
  2. Contributors
  3. Self-merging rule

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Test data in OCA runbots

Leaving Camptocamp and OCA

Avatar

Self-merging rule

by Pedro Manuel Baeza Romero <pedro.baeza@gmail.com> - 23/08/2015 14:16:59
Hi all,

I faced some days ago a complaint from Stefan Rijnhart about myself merging one of my PRS when the number of approvals was the appropiate. This is an old OCA rule that was applied on old Launchpad times.

This rule is not even in the current OCA contributing guidelines (https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#review), but he insists on bringing this topic to the mailing list.

I see no special reason to apply again this rule nowadays, because thanks to the merge button, the task doesn't involve any special risk to screw up things. In Launchpad, there was this risk, as the merge implies some manual operations that can lead to a bad merging, but as I said, today this is not a problem.

What the others think about this rule?

Regards.

Follow-Ups