Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: Backports and license

by
Tecnativa. S. L., Pedro M. Baeza
- 25/06/2015 08:21:34
I don't think that's the case for Odoo, because it's not a common practice to take just one file of the module, but the whole one. Anyways, the chance of having an incorrect copyright header is very high, because contributors don't maintain them correctly (because it's very tedious and error prone). So I prefer to have an easy and centralized convention that makes people to follow it correctly that one with benefits in a theoretical split of the code, but that it's going to be incorrect in most cases.

Regards.

2015-06-24 23:08 GMT+02:00 Ronald Portier <ronald@therp.nl>:
Hello, In the past I also was in favor of one centralized license / copyright file. However I have been convinced by post as the following, that is really is better to have them in each source file: http://lu.is/blog/2012/03/17/on-the-importance-of-per-file-license-information/ Not going to repeat everything stated in this (and other) posts, but the main point is that open source is about free re-use. So different files can become separated from the original project all the time (and that is a good thing!). For the community modules it is also the case that while generally they will be all AGPL, the copyright of each file might be different, because many contributors will keep their own copyright (beside granting the OCA a copyright through the CLA). I am also not a lawyer, but this is what I am thinking. Kind regards, Ronald Op 24-06-15 om 21:38 schreef Alejandro Santana: > It has been discussed before, even proposing some new (pseudo?) > standards, but no common direction was stablished. > > I am also in favor of minimum header in files, just pointing to > __openerp__.py file for all info. > Having all authoring info in each file (and maybe with different > collaborators in each one) makes it much more difficult to see actual > authorship. > > Just my 2 cents. > > > > -- > *Alejandro Santana* > alejandrosantana@anubia.es <mailto:alejandrosantana@anubia.es> > · · · · · · · · · · · · · · · · · · · · · · · · · · · · · > > ANUBÍA, soluciones en la nube, S.L. > > Colón 26, planta 3, oficina 1 > 36201, Vigo (Pontevedra) > > www.anubia.es > > > anubía_logo_2014_i_o_140x140.pngodoo_logo_odoo_ready_140x140.png > > > > > 2015-06-24 21:22 GMT+02:00 Pedro Manuel Baeza Romero > : > > Well, I don't think a bloated header on each file is needed. Only > __openerp__.py header contains all the copyright information, and > git makes the rest. > > Regards. > > 2015-06-24 20:23 GMT+02:00 Markus Schneider > : > > Hi Pedro, thanks a lot. So to summaries this, for the next case: > - make sure keep original git history - adding proper license > header to all files with original author something else? Kind > Regards Markus On 24.06.2015 17:07, Pedro@pad.odoo-community.org > <mailto:Pedro@pad.odoo-community.org> wrote: > In this case, > they didn't do it due to a lack of knowledge on how to do > it. > I will teach then and redo the PR. > > Regards. > > 2015-06-23 > 12:08 GMT+02:00 Alexandre Fayolle > > <alexandre.fayolle@camptocamp.com > <mailto:alexandre.fayolle@camptocamp.com> > > <mailto:alexandre.fayolle@camptocamp.com > <mailto:alexandre.fayolle@camptocamp.com>>>: > > > The PR > completely removed history, contributors' names... :-( > > > > > On 23/06/2015 11:52, Joël Grand-Guillaume wrote: > > > cite="mid:CACk3wO+Z17OeNgFrFe=3q7HMti2if9Bk3yJGQE3xk8Fhxj32Cg@mail.gmail.com > <mailto:3q7HMti2if9Bk3yJGQE3xk8Fhxj32Cg@mail.gmail.com> > > <mailto:3q7HMti2if9Bk3yJGQE3xk8Fhxj32Cg@mail.gmail.com > <mailto:3q7HMti2if9Bk3yJGQE3xk8Fhxj32Cg@mail.gmail.com>>" > type="cite"> > +1 > > the license is still AGPL : > > https://github.com/odoo/odoo/blob/master/LICENSE > > On Tue, > Jun 23, 2015 at 9:38 AM, <Pedro@pad.odoo-community.org > <mailto:Pedro@pad.odoo-community.org> > > <mailto:Pedro@pad.odoo-community.org > <mailto:Pedro@pad.odoo-community.org>>> wrote: > > Hi, > Markus, > > I have already done backports and I have kept > the headers of the > files as is. In this case, the original > code is also without > headers: for example, > > https://github.com/odoo/odoo/blob/master/addons/website_slides/models/res_config.py
> , > and about license, it is yet in the odoo repositories > without > LGPL statement, so it can be assumed that it's > AGPL. > > Regards. > > 2015-06-22 21:53 GMT+02:00 Markus > Schneider > : > > hi OCA, > > > https://github.com/OCA/website/pull/44 > > > is a backport of website_slides but their is no license > information. > I would ask (maybe it is documented > somewhere), do we accepted > backports? How we document of > the initial version take with source? > > Kind Regards > > > Markus > OCA/website maintainer > > > _______________________________________________ > > Mailing-List: > > http://odoo-community.org/groups/oca-contributors-15 > Post > to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > > <mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org>> > Unsubscribe: > http://odoo-community.org/groups?unsubscribe > > > > _______________________________________________ > > Mailing-List: > http://odoo-community.org/groups/oca-contributors-15 > Post > to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > > <mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org>> > Unsubscribe: > http://odoo-community.org/groups?unsubscribe > > > > > > -- > > > *camptocamp* > INNOVATIVE SOLUTIONS > BY > OPEN SOURCE EXPERTS > > *Joël Grand-Guillaume* > Division > Manager > Business Solutions > > +41 21 619 10 28 21 619 10 28> > www.camptocamp.com > > > > _______________________________________________ > > Mailing-List: > http://odoo-community.org/groups/oca-contributors-15> Post > to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > Unsubscribe: > http://odoo-community.org/groups?unsubscribe > > > > -- > > Alexandre Fayolle > Chef de Projet > Tel : +33 4 58 48 20 30 > > > Camptocamp France SAS > Savoie > Technolac, BP 352 > 73377 Le Bourget du Lac Cedex > > http://www.camptocamp.com > > > _______________________________________________ > > Mailing-List: > http://odoo-community.org/groups/oca-contributors-15> Post > to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > > <mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org>> > Unsubscribe: > http://odoo-community.org/groups?unsubscribe > > > > _______________________________________________ > > Mailing-List: > http://odoo-community.org/groups/oca-contributors-15 > Post > to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > Unsubscribe: > http://odoo-community.org/groups?unsubscribe > -- > Dipl.-Comp.-Math. Markus Schneider Softwareentwickler > initOS GmbH & Co. KG An der Eisenbahn 1 21224 Rosengarten > Mobil: +49 (0)172 2303699 2303699>Phone: +49 (0)4105 5615613 5615613> Fax: +49 (0)4105 5615610 5615610> Email: markus.schneider@initos.com > <mailto:markus.schneider@initos.com> Web: > http://www.initos.com Geschäftsführung: Dipl. Wirt.-Inf. > Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke Haftende > Gesellschafterin: initOS Verwaltungs GmbH Sitz der > Gesellschaft: Rosengarten – Klecken Amtsgericht Tostedt, HRA > 201840 USt-IdNr: DE 275698169 Steuer-Nr: 15/205/21402 > > _______________________________________________ > Mailing-List: http://odoo-community.org/groups/oca-contributors-15 > Post to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > Unsubscribe: http://odoo-community.org/groups?unsubscribe > > > _______________________________________________ > Mailing-List: http://odoo-community.org/groups/oca-contributors-15 > Post to: mailto:contributors@odoo-community.org > <mailto:contributors@odoo-community.org> > Unsubscribe: http://odoo-community.org/groups?unsubscribe > > > _______________________________________________ > Mailing-List: http://odoo-community.org/groups/oca-contributors-15 > Post to: mailto:contributors@odoo-community.org > Unsubscribe: http://odoo-community.org/groups?unsubscribe >

_______________________________________________
Mailing-List: http://odoo-community.org/groups/oca-contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


Reference