Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

100 % coverage not enough?

by "Ronald Portier" <rportier@therp.nl> - 08/09/2023 20:52:07
Hi all,


I submitted a PR with 100% code coverage to the account-invoicing repo.


However the branch is red because 100% is apparently not enough. 
Supposedly the PR would decrease the overall coverage percentage. How??


See here: https://github.com/OCA/account-invoicing/pull/1544


I think any PR that gets code coverage > 90% (and that does not decrease 
coverage of an existing module), should get a branch green, but 
certainly 100%.


Kind regards, Ronald


Follow-Ups