Contributors mailing list archives

contributors@odoo-community.org

Re: New Github Review Options

by
LasLabs, Dave Lasley
- 20/09/2016 06:49:36
I noticed CI only fails when the review comes from a PSC. Is it so?

It is!

We can’t configure the amount of reviews, it is static one per PR. This seems that this fits our rule of requiring one :+1 w/ write access to the repo though, so I think we’re good.

One catch is if someone blocks, they have to unblock or an admin has to override. IMO this is also fine, we ping each other on our blockers anyways - this is just more formal & less likely to be missed.


On Sep 19, 2016, at 3:38 AM, Jairo Llopis <jairo.llopis@tecnativa.com> wrote:


2016-09-17 0:52 GMT+02:00 Eric Caudal <eric.caudal@elico-corp.com>:
I propose that we implement these rules (2 approvals required) on OCA repos so that the review approval process is part of our standard CI spot. 

I noticed CI only fails when the review comes from a PSC. Is it so?


--
Jairo Llopis