Contributors mailing list archives
contributors@odoo-community.org
Browse archives
Re: New Github Review Options
by
LasLabs, Dave Lasley
I noticed CI only fails when the review comes from a PSC. Is it so?
It is!
We can’t configure the amount of reviews, it is static one per PR. This seems that this fits our rule of requiring one :+1 w/ write access to the repo though, so I think we’re good.
One catch is if someone blocks, they have to unblock or an admin has to override. IMO this is also fine, we ping each other on our blockers anyways - this is just more formal & less likely to be missed.
Thank you,
Dave Lasley - LasLabs
Founder / CEO
<img height="49" width="50" apple-inline="yes" id="BB58E745-D121-4CFC-8F0C-D6DE7425745F" apple-width="yes" apple-height="yes" src="cid:B6781F39-FEE7-4B4E-91AD-FDB83E4A18E3@dlasley.net" class="">
On Sep 19, 2016, at 3:38 AM, Jairo Llopis <jairo.llopis@tecnativa.com> wrote:2016-09-17 0:52 GMT+02:00 Eric Caudal <eric.caudal@elico-corp.com>:I propose that we implement these rules (2 approvals required) on OCA repos so that the review approval process is part of our standard CI spot.I noticed CI only fails when the review comes from a PSC. Is it so?
--Jairo Llopis_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe
Reference
-
New Github Review Options
byLasLabs, Dave Lasley- 15/09/2016 22:00:46 - 3-
-
Re: New Github Review Options
by Jairo Llopis <jairo.llopis@tecnativa.com> - 19/09/2016 12:24:28 - 0 -
Re: New Github Review Options
byOpen Source Integrators, Maxime Chambreuil- 17/09/2016 16:45:45 - 0 -
-
-
